Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #5887 to stable2407 #6674

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

s0me0ne-unkn0wn
Copy link
Contributor

This PR accompanies #6672 to make backported changes consistent across releases.

@s0me0ne-unkn0wn s0me0ne-unkn0wn added the A3-backport Pull request is already reviewed well in another branch. label Nov 27, 2024
@s0me0ne-unkn0wn s0me0ne-unkn0wn marked this pull request as ready for review November 27, 2024 12:59
@s0me0ne-unkn0wn s0me0ne-unkn0wn changed the title Backport #5887 to v1.14 crates releas Backport #5887 to stable2407 Nov 27, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev merged commit c29cf6e into stable2407 Dec 3, 2024
15 of 18 checks passed
@EgorPopelyaev EgorPopelyaev deleted the s0me0ne/backport-5887-to-stable2407 branch December 3, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants