Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409] Backport #6506 #6658

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #6506 into stable2409 from Dinonard.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6506-to-stable2409
git worktree add --checkout .worktree/backport-6506-to-stable2409 backport-6506-to-stable2409
cd .worktree/backport-6506-to-stable2409
git reset --hard HEAD^
git cherry-pick -x f520adb0aacd51247ed548c7db9bef874c2cca9e
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Nov 26, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev
Copy link
Contributor

@Dinonard Hey Dino, is this PR ready for review?

@Dinonard
Copy link
Contributor

Dinonard commented Dec 9, 2024

Sorry @EgorPopelyaev, hadn't noticed this PR was created.

The test files needs minor adjustment, but I'm not sure how can I do this without opening another PR?
I'm not allowed to modify the content of this branch.

@EgorPopelyaev
Copy link
Contributor

@Dinonard I've deleted the leftover lines from merge. Is there anything else which is needs to be adjusted?

@EgorPopelyaev EgorPopelyaev marked this pull request as ready for review December 11, 2024 08:55
@EgorPopelyaev EgorPopelyaev requested a review from a team as a code owner December 11, 2024 08:55
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7899119

@Dinonard
Copy link
Contributor

@EgorPopelyaev the test no_fee_and_no_weight_for_other_origins wasn't part of my PR, everything else seems fine.

@EgorPopelyaev EgorPopelyaev merged commit 940966e into stable2409 Dec 11, 2024
55 of 117 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6506-to-stable2409 branch December 11, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants