Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmp: Check that the para exist before delivering a message #6604

Merged
merged 34 commits into from
Dec 12, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Nov 21, 2024

No description provided.

@bkchr bkchr added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Nov 21, 2024
@bkchr
Copy link
Member Author

bkchr commented Nov 29, 2024

/cmd prdoc --audience runtime_dev --bump patch

prdoc/pr_6604.prdoc Outdated Show resolved Hide resolved
@bkontur
Copy link
Contributor

bkontur commented Nov 29, 2024

for those failed rococo/westend benchmarks, for ToParachainDeliveryHelper e.g. here adding some EnsureForParachain implementation which does that paras::Heads::<Runtime>::insert(p, HeadData(p.encode().into())); should fix it (this is needed just for relaychains, which does dmp)

@bkontur
Copy link
Contributor

bkontur commented Nov 29, 2024

there is also one place: https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/parachains/src/hrmp.rs#L1886-L1898, I am not sure if this new Unroutable could happen in this place, maybe we could change that e.g.:

                // try to enqueue
		if let Err(error) =
			dmp::Pallet::<T>::queue_downward_message(&config, dest, notification_bytes)
		{
			// this should never happen unless the max downward message size is configured to a
			// jokingly small number or para is not registered/active.
			log::error!(
				target: "runtime::hrmp",
				"sending '{log_label}::notification_bytes' failed with error: {error:?}."
			);
			debug_assert!(false);
		}

@bkontur
Copy link
Contributor

bkontur commented Nov 30, 2024

for those failed rococo/westend benchmarks, for ToParachainDeliveryHelper e.g. here adding some EnsureForParachain implementation which does that paras::Heads::<Runtime>::insert(p, HeadData(p.encode().into())); should fix it (this is needed just for relaychains, which does dmp)

let me fix this for you

@bkchr
Copy link
Member Author

bkchr commented Nov 30, 2024

let me fix this for you

I already have it fixed locally :) Just need to fix more :D

@bkchr bkchr requested a review from a team as a code owner November 30, 2024 21:47
@bkontur
Copy link
Contributor

bkontur commented Nov 30, 2024

let me fix this for you

I already have it fixed locally :) Just need to fix more :D

:D :D nice, so at least please consider one small clean-up of my older code: #6714

@bkchr bkchr enabled auto-merge December 9, 2024 21:49
@bkchr
Copy link
Member Author

bkchr commented Dec 10, 2024

/cmd prdoc --audience runtime_dev --bump major

Copy link

Command "prdoc --audience runtime_dev --bump major" has failed ❌! See logs here

@bkchr
Copy link
Member Author

bkchr commented Dec 10, 2024

/cmd prdoc --audience runtime_dev --bump major --force

prdoc/pr_6604.prdoc Outdated Show resolved Hide resolved
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12285796959
Failed job name: test-linux-stable-no-try-runtime

@bkchr bkchr added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit c10e25a Dec 12, 2024
197 of 199 checks passed
@bkchr bkchr deleted the bkchr-dmp-check-para-exists branch December 12, 2024 17:44
@bkchr bkchr added the A4-needs-backport Pull request must be backported to all maintained releases. label Dec 18, 2024
@paritytech-cmd-bot-polkadot-sdk

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6604-to-stable2407
git worktree add --checkout .worktree/backport-6604-to-stable2407 backport-6604-to-stable2407
cd .worktree/backport-6604-to-stable2407
git reset --hard HEAD^
git cherry-pick -x c10e25aaa8b8afd8665b53f0a0b02e4ea44caa77
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk

Created backport PR for stable2409:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6604-to-stable2409
git worktree add --checkout .worktree/backport-6604-to-stable2409 backport-6604-to-stable2409
cd .worktree/backport-6604-to-stable2409
git reset --hard HEAD^
git cherry-pick -x c10e25aaa8b8afd8665b53f0a0b02e4ea44caa77
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk

Created backport PR for stable2412:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6604-to-stable2412
git worktree add --checkout .worktree/backport-6604-to-stable2412 backport-6604-to-stable2412
cd .worktree/backport-6604-to-stable2412
git reset --hard HEAD^
git cherry-pick -x c10e25aaa8b8afd8665b53f0a0b02e4ea44caa77
git push --force-with-lease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-needs-backport Pull request must be backported to all maintained releases. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants