Migrate pallet-timestamp to umbrella crate
#6523
Open
+20
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
User @bennethxyz, please sign the CLA here. |
91 tasks
|
@kianenigma @re-gius, I took note of the guidelines and hopefully recent changes serves as a reference to my understanding. Please review. Also realized that if systems are needed from the |
re-gius
added
R0-silent
re-gius
approved these changes
Dec 17, 2024
| use sp_runtime::traits::{AtLeast32Bit, SaturatedConversion, Scale, Zero}; | ||
| use frame::{ | ||
| runtime::prelude::*, | ||
| traits::{AtLeast32Bit, OnTimestampSet, Scale, Time, UnixTime}, |
There was a problem hiding this comment.
AtLeast32Bit appears in many pallets, we should add it to the umbrella crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify
pallet-timestampto use umbrella crate systems, following the guidelines regarding whole prelude imports.Part of #6504