Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #6304 to stable2412 #6470

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Backport #6304 to stable2412 #6470

merged 2 commits into from
Nov 19, 2024

Conversation

franciscoaguirre
Copy link
Contributor

Backporting the new V5 ExecuteWithOrigin instruction to stable2412

@github-actions GitHub Actions
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@franciscoaguirre @acatangiu
@x3c41a @bkontur @programskillforverification @nazar-pc @bkchr @shawntabrizi
XCMv5: add ExecuteWithOrigin instruction (#6304)
413f900 
Added `ExecuteWithOrigin` instruction according to the old XCM RFC 38:
polkadot-fellows/xcm-format#38.

This instruction allows you to descend or clear while going back again.

- [x] Implementation
- [x] Unit tests
- [x] Integration tests
- [x] Benchmarks
- [x] PRDoc

Modify `WithComputedOrigin` barrier to allow, for example, fees to be
paid with a descendant origin using this instruction.

---------

Signed-off-by: Adrian Catangiu <[email protected]>
Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: Andrii <[email protected]>
Co-authored-by: Branislav Kontur <[email protected]>
Co-authored-by: Joseph Zhao <[email protected]>
Co-authored-by: Nazar Mokrynskyi <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Shawn Tabrizi <[email protected]>
Co-authored-by: command-bot <>
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Nov 13, 2024
@franciscoaguirre franciscoaguirre self-assigned this Nov 13, 2024
@franciscoaguirre franciscoaguirre enabled auto-merge (squash) November 18, 2024 23:49
@EgorPopelyaev EgorPopelyaev merged commit a0190f6 into stable2412 Nov 19, 2024
195 of 198 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6304-to-stable2412 branch November 19, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkontur bkontur bkontur approved these changes

Assignees

@franciscoaguirre franciscoaguirre

Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franciscoaguirre @bkontur @EgorPopelyaev