[pallet-revive] Support all eth tx types #6461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cmd prdoc --audience runtime_dev --bump minor |
|
Command "prdoc --audience runtime_dev --bump minor" has failed ❌! See logs here |
|
updating a few more left over Legacy tx usage |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
athei
approved these changes
Nov 21, 2024
xermicus
approved these changes
Nov 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for all eth tx types
Note that js libs will continue to use the Legacy type since we don't include base_fee_per_gas yet in the block.
We can think about setting these values after we revisit how we encode the gas into weight & deposit_limit in a follow up PR