wasm-builder: Use riscv32emac-unknown-none-polkavm.json target #6419
Conversation
jarkkojs
force-pushed
the
wasm-builder-riscv32emac
branch
22 times, most recently
from
5199aa3 to
005ec4a
Compare
|
How do I pass |
jarkkojs
force-pushed
the
wasm-builder-riscv32emac
branch
5 times, most recently
from
283e8b0 to
5205e58
Compare
…v32emac Signed-off-by: Jarkko Sakkinen <[email protected]>
Co-authored-by: Koute <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
82117ad
…ytech#6419) # Description Closes paritytech#6335. ## Integration N/A ## Review Notes `RuntimeTarget` is converted to return path to the custom target JSON file --------- Signed-off-by: Jarkko Sakkinen <[email protected]> Co-authored-by: Alexander Theißen <[email protected]> Co-authored-by: Koute <[email protected]>
…ytech#6419) # Description Closes paritytech#6335. ## Integration N/A ## Review Notes `RuntimeTarget` is converted to return path to the custom target JSON file --------- Signed-off-by: Jarkko Sakkinen <[email protected]> Co-authored-by: Alexander Theißen <[email protected]> Co-authored-by: Koute <[email protected]>
| // This is a nightly-only flag. | ||
| let arg = match self { | ||
| RuntimeTarget::Wasm => "build-std", | ||
| RuntimeTarget::Riscv => "build-std=core,alloc", |
There was a problem hiding this comment.
It is required for both targets but for different reasons:
wasm: The rustup provided standard library is compiled with wasm extensions enabled we dont support. Hence we need to recompile it.
riscv: Rustup doesn't contain any prebuilt binaries for this target. Hence we need to build it ourselves.
There was a problem hiding this comment.
Yeah, so I guessed, i.e. it should be official target in rustc upstream to have prebuilt binaries, right?
There was a problem hiding this comment.
[not actually at work yet, my keyboard just writes by itself]
There was a problem hiding this comment.
@athei Thanks for the clarification! I think Parity could add to the pre-compiled libraries to riscv32emac-unknown-none-polkavm target in rlib format like the wasm32-unknown-unknown target does (located in ./lib/rustlib/wasm32-unknown-unknown/lib/libcore-192e883b194683b6.rlib).
Description
Closes #6335.
Integration
N/A
Review Notes
RuntimeTargetis converted to return path to the custom target JSON file