pallet-utility: if_else
#6321
pallet-utility: if_else
#6321
Conversation
|
User @rainbow-promise, please sign the CLA here. |
|
Need to take a closer look at the extrinsic executions, even with the revisions it Is not quit there yet. |
|
looks fine now. need proper weights |
|
I am guessing the weight signature below the pallet index will have some form of condition as well? |
|
use the worst case (i.e. main + fallback). extra weight will be refunded as the actual weight is returned in the call |
this also applies to dispatch class? |
I would say dispatch class is the lowest class of the 2. if both are operational then it is operational. if one is normal then it is normal. etc. |
how can one determine the class of a |
take a look at batch, they do similar operation. You can use |
|
Also the |
| let caller = whitelisted_caller(); | ||
|
|
||
| #[extrinsic_call] | ||
| _(RawOrigin::Signed(caller), main_call, fallback_call); |
There was a problem hiding this comment.
The err branch should be slightly more costly, but difference should be negligible so it is ok.
There was a problem hiding this comment.
Ok.
Thanks for the review
There was a problem hiding this comment.
You can use a root call, it will be failing, like set_heap_page.
This would benchmark for the failing case, which is more costly
There was a problem hiding this comment.
...
#[benchmark]
fn if_else() {
let main_call = Box::new(frame_system::Call::set_heap_pages { pages: 0u64 }.into());
let fallback_call = Box::new(frame_system::Call::remark { remark: vec![1] }.into());
let caller = whitelisted_caller();
#[extrinsic_call]
_(RawOrigin::Signed(caller), main_call, fallback_call);
assert_last_event::<T>(
Event::IfElseFallbackCalled {
main_error: sp_runtime::DispatchError::Module(sp_runtime::ModuleError {
index: 0,
error: [5, 0, 0, 0],
message: None,
}),
}
.into(),
);
}There was a problem hiding this comment.
@gui1117 the event passes for cargo test -p pallet-utility --features runtime-benchmarks
but fails when building for most runtimes
There was a problem hiding this comment.
can you give an example of fail when building runtime? it seems to work for me, do you have a command to reproduce?
There was a problem hiding this comment.
Yeah, best to use other pallets for this benchmark case.
There was a problem hiding this comment.
I don't understand what you mean, can you say again?
There was a problem hiding this comment.
Mean to ask if importing other pallets and using their call enum is possible?
There was a problem hiding this comment.
no I think pallet utility can't assume usage of any other pallet than system.
but fails when building for most runtimes
But what is the command you run that resulted in a runtime failing to build?
|
/tip medium |
|
@shawntabrizi A referendum for a medium (80 DOT) tip was successfully submitted for @rainbow-promise (1HbdqutFR8M535LpbLFT41w3j7v9ptEYGEJKmc6PKpqthZ8 on polkadot). Referendum number: 1327. |
|
The referendum has appeared on Polkassembly. |
|
@rainbow-promise did you sign the CLA in the first message #6321 (comment) ? |
@gui1117 I did, any reason why it pops up on new PRs? |
I have no idea, I see the CI test is failing, but it doesn't say much. |
|
@gui1117 Still the same with a different browser. |
Thanks I will try to see internally |
|
My email address was set to private, I thought that could resolve the issue |
|
/cla run-cla-check |
|
Queueing command execution: run-cla-check |
|
@gui1117 Command execution has finished. |
|
Hey @rainbow-promise, I've checked |
Utility Call Fallback
This introduces a new extrinsic:
if_elseWhich first attempts to dispatch the
maincall(s). If themaincall(s) fail, thefallbackcall(s) is dispatched instead. Both calls are executed with the same origin.In the event of a fallback failure the whole call fails with the weights returned.
Use Case
Some use cases might involve submitting a
batchtype call in either main, fallback or both.Resolves #6000
Polkadot Address: 1HbdqutFR8M535LpbLFT41w3j7v9ptEYGEJKmc6PKpqthZ8