[pallet-revive] revive json-rpc small adjustments #6309
Conversation
pgherveou
added
R0-silent
|
/cmd prdoc --audience runtime_dev --bump patch |
| @@ -165,7 +164,7 @@ impl From<ClientError> for ErrorObjectOwned { | |||
|
|
|||
| /// The number of recent blocks maintained by the cache. | |||
| /// For each block in the cache, we also store the EVM transaction receipts. | |||
| pub const CACHE_SIZE: usize = 10; | |||
| pub const CACHE_SIZE: usize = 256; | |||
There was a problem hiding this comment.
How did you come up with this number? Might be worth to explain it in above comment.
There was a problem hiding this comment.
just a random number :)
that's how many block we keep in the cache for answering eth json-rpc requests, 10 was probably too low
so bumping it just to be safe, I will probably revisit that later
There was a problem hiding this comment.
What is the memory used in the worst-case scenario for caching one block?
There was a problem hiding this comment.
did not check but it should be pretty light, we can adapt this code later on so that it does not grow more than let's say 100mb
Co-authored-by: Niklas Adolfsson <[email protected]>
|
cherry picking these changes into a single PR here #6317 |
Pull request was closed
Small adjustments to eth-rpc