Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pallet-glutton benchmark to v2 #6296

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Migrate pallet-glutton benchmark to v2 #6296

merged 8 commits into from
Nov 4, 2024

Conversation

AurevoirXavier
Copy link
Contributor

@AurevoirXavier AurevoirXavier requested a review from a team as a code owner October 30, 2024 15:32
@AurevoirXavier AurevoirXavier mentioned this pull request Oct 30, 2024
Open
43 tasks
@ggwpez
Copy link
Member

ggwpez commented Oct 30, 2024

/cmd prdoc --bump patch --audience runtime_dev

@ggwpez ggwpez added T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Oct 30, 2024
re-gius
re-gius approved these changes Nov 4, 2024
View reviewed changes
substrate/frame/glutton/src/benchmarking.rs Outdated Show resolved Hide resolved
substrate/frame/glutton/src/benchmarking.rs Show resolved Hide resolved
seadanda
seadanda approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@seadanda seadanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo these very minor comments. I can resolve and merge to avoid re-review

prdoc/pr_6296.prdoc Outdated Show resolved Hide resolved
substrate/frame/glutton/src/benchmarking.rs Show resolved Hide resolved
@seadanda seadanda enabled auto-merge November 4, 2024 10:27
@seadanda seadanda added this pull request to the merge queue Nov 4, 2024
Merged via the queue into paritytech:master with commit f4ded5c Nov 4, 2024
197 of 198 checks passed
@AurevoirXavier AurevoirXavier deleted the benchmarkv2-glutton branch November 4, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@re-gius re-gius re-gius approved these changes

@seadanda seadanda seadanda approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AurevoirXavier @ggwpez @seadanda @re-gius @actions-user