Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2407] Backport #6148 #6232

Open
wants to merge 5 commits into
base: stable2407
Choose a base branch
from
Open

[stable2407] Backport #6148 #6232

wants to merge 5 commits into from

Commits on Oct 28, 2024

  1. Fix migrations for pallet-xcm (#6148) 

    Relates to: #4826
Relates to: #3214

`pallet-xcm` stores some operational data that uses `Versioned*` XCM
types. When we add a new XCM version (XV), we deprecate XV-2 and remove
XV-3. Without proper migration, this can lead to issues with
[undecodable
storage](https://github.com/paritytech/polkadot-sdk/actions/runs/11381324568/job/31662577532?pr=6092),
as was identified on the XCMv5 branch where XCMv2 was removed.

This PR extends the existing `MigrateToLatestXcmVersion` to include
migration for the `Queries`, `LockedFungibles`, and
`RemoteLockedFungibles` storage types. Additionally, more checks were
added to `try_state` for these types.

- [x] create tracking issue for `polkadot-fellows`
polkadot-fellows/runtimes#492
- [x] Add missing `MigrateToLatestXcmVersion` for westend
- [x] fix pallet-xcm `Queries`
- fails for Westend
https://github.com/paritytech/polkadot-sdk/actions/runs/11381324568/job/31662577532?pr=6092
- `V2` was removed from `Versioned*` stuff, but we have a live data with
V2 e.g. Queries - e.g. Kusama or Polkadot relay chains
```
VersionNotifier: {
        origin: {
          V2: {
            parents: 0
            interior: {
              X1: {
                Parachain: 2,124
              }
            }
          }
        }
        isActive: true
      }
```

![image](https://github.com/user-attachments/assets/f59f761b-46a7-4def-8aea-45c4e41c0a00)
- [x] fix also for `RemoteLockedFungibles`
- [x] fix also for `LockedFungibles`

- [ ] deploy on Westend chains before XCMv5
- [ ] #6188

---------

Co-authored-by: command-bot <>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Francisco Aguirre <[email protected]>
(cherry picked from commit efd6603)
    @bkontur
    bkontur committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    07bf954 View commit details
    Browse the repository at this point in the history

  2. Missing tracing

    @bkontur
    bkontur committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    fc198bf View commit details
    Browse the repository at this point in the history

  3. Cargo.lock

    @bkontur
    bkontur committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    104e2a2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'stable2407' into backport-6148-to-stable2407

    @bkontur
    bkontur authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    5c77ede View commit details
    Browse the repository at this point in the history

  5. taplo

    @bkontur
    bkontur committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    e864230 View commit details
    Browse the repository at this point in the history