[stable 2407] Backport #5741 #6114
Conversation
Close #5589 This PR makes it possible for `rpc_v2::Storage::query_iter_paginated` to be "backpressured" which is achieved by having a channel where the result is sent back and when this channel is "full" we pause the iteration. The chainHead_follow has an internal channel which doesn't represent the actual connection and that is set to a very small number (16). Recall that the JSON-RPC server has a dedicate buffer for each connection by default of 64. - Because `archive_storage` also depends on `rpc_v2::Storage::query_iter_paginated` I had to tweak the method to support limits as well. The reason is that archive_storage won't get backpressured properly because it's not an subscription. (it would much easier if it would be a subscription in rpc v2 spec because nothing against querying huge amount storage keys) - `query_iter_paginated` doesn't necessarily return the storage "in order" such as - `query_iter_paginated(vec![("key1", hash), ("key2", value)], ...)` could return them in arbitrary order because it's wrapped in FuturesUnordered but I could change that if we want to process it inorder (it's slower) - there is technically no limit on the number of storage queries in each `chainHead_v1_storage call` rather than the rpc max message limit which 10MB and only allowed to max 16 calls `chainHead_v1_x` concurrently (this should be fine) - Iterate over 10 accounts on westend-dev -> ~2-3x faster - Fetch 1024 storage values (i.e, not descedant values) -> ~50x faster - Fetch 1024 descendant values -> ~500x faster The reason for this is because as Josep explained in the issue is that one is only allowed query five storage items per call and clients has make lots of calls to drive it forward.. --------- Co-authored-by: command-bot <> Co-authored-by: James Wilson <[email protected]>
|
This pull request is amending an existing release. Please proceed with extreme caution,
Emergency Bypass
If you really need to bypass this check: add |
niklasad1
added
the
A3-backport
substrate/client/rpc-spec-v2/src/chain_head/chain_head_storage.rs
Outdated
Show resolved
Hide resolved
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
| } | ||
| } | ||
|
|
||
| impl<Client, Block, BE> ChainHeadStorage<Client, Block, BE> | ||
| where | ||
| Block: BlockT + 'static, | ||
| BE: Backend<Block> + 'static, | ||
| Client: StorageProvider<Block, BE> + 'static, | ||
| Client: StorageProvider<Block, BE> + Send + Sync + 'static, |
There was a problem hiding this comment.
arrgh breaking change, normally this will just be the substrate client which is already send + sync but probably a blocker for backporting this then?
|
Not possible to backport, breaking change closing |
Backport #5741