Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrations for pallet-xcm #6099

Closed
wants to merge 34 commits into from
Closed

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Oct 17, 2024

Relates to: #4826

TODO": Investigate MigrateToLatestXcmVersion why it does not migrate Queries with V2, maybe we need to add another migration when removing older versions.

TODO

VersionNotifier: {
        origin: {
          V2: {
            parents: 0
            interior: {
              X1: {
                Parachain: 2,124
              }
            }
          }
        }
        isActive: true
      } 

image

  • fix also for RemoteLockedFungibles
  • fix also for LockedFungibles
  • what about RecordedXcm?

@bkontur bkontur added the T6-XCM This PR/Issue is related to XCM. label Oct 17, 2024
@bkontur bkontur mentioned this pull request Oct 17, 2024
11 tasks
franciscoaguirre and others added 3 commits October 17, 2024 15:35
Implements [RFC#105](polkadot-fellows/RFCs#105)
which, at the time of this PR, has not been approved yet. Some aspects
might be changed as a result of discussion.

## TODO
- [x] Add new instruction and use it in conversion functions
- [x] Implement in xcm-executor
- [x] Setup for xcm-executor unit tests
- [x] Actual xcm-executor unit tests
  - [x] Happy path
  - [x] Unhappy path
- [x] Emulated tests
  - [x] Asset hub westend
  - [x] Asset hub rococo
- [x] Benchmarks
  - [x] Dummy values
  - [x] Actual benchmarks
- [x] PRDoc

---------

Co-authored-by: command-bot <>
Co-authored-by: Adrian Catangiu <[email protected]>
@bkontur bkontur changed the title Fix migrations for XCMv5 Fix migrations for pallet-xcm Oct 21, 2024
@bkontur bkontur changed the base branch from xcm-v5 to master October 21, 2024 08:10
@bkontur bkontur requested a review from a team as a code owner October 21, 2024 08:10
@paritytech-review-bot paritytech-review-bot bot requested a review from a team October 21, 2024 08:11
@bkontur
Copy link
Contributor Author

bkontur commented Oct 21, 2024

will be fixed on the master instead of xcm-v5 branch,
closing in favor of #6148

@bkontur bkontur closed this Oct 21, 2024
@bkontur bkontur deleted the bko-xcm-v5-fix-migrations branch October 21, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants