Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Versioned*::from instead of concrete V* when using xcm::latest #6092

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Oct 16, 2024

Relates to: #5420

This PR includes some cleanup, as every time we upgrade XCM, we will need to rewrite all instances of V5 to V6.

@bkontur bkontur added R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM. labels Oct 16, 2024
@bkontur bkontur requested a review from a team as a code owner October 16, 2024 13:28
@bkontur bkontur mentioned this pull request Oct 16, 2024
13 tasks
@paritytech-review-bot paritytech-review-bot bot requested a review from a team October 16, 2024 13:30
@bkontur
Copy link
Contributor Author

bkontur commented Oct 16, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 16, 2024

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7585452 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-65aff994-3365-4db9-980d-37f534a05fb2 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 16, 2024

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7585452 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7585452/artifacts/download.

@bkontur
Copy link
Contributor Author

bkontur commented Oct 17, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 17, 2024

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7590940 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 12-21159060-7e2f-43bc-b126-75b249ded560 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 17, 2024

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7590940 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7590940/artifacts/download.

@bkontur
Copy link
Contributor Author

bkontur commented Oct 17, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 17, 2024

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7591194 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 13-dce470e7-1be6-4cae-94d3-c3d13b41f71d to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 17, 2024

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7591194 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7591194/artifacts/download.

@bkontur bkontur merged commit 8b49830 into xcm-pay-fees Oct 17, 2024
244 of 320 checks passed
@bkontur bkontur deleted the bko-on-xcm-pay-fees branch October 17, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants