Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridges - add version guarding for standalone relaying of parachains and messages #5952

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Bridges - add version guarding for standalone relaying of parachains and messages #5952

merged 6 commits into from
Oct 7, 2024

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Oct 7, 2024

This PR adds the ability to start version guarding when performing standalone relaying of messages and parachains.

Follow-up

@bkontur bkontur added R0-silent Changes should not be mentioned in any release notes T15-bridges This PR/Issue is related to bridges. labels Oct 7, 2024
@bkontur
Copy link
Contributor Author

bkontur commented Oct 7, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 7, 2024 •
edited
Loading

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7523999 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 23-525c9ba5-b66e-437e-9b93-913ccf9321c3 to cancel this command or bot cancel to cancel all commands in this pull request.

@paritytech-review-bot paritytech-review-bot bot requested a review from a team October 7, 2024 13:06
@command-bot
Copy link

command-bot bot commented Oct 7, 2024

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7523999 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7523999/artifacts/download.

@bkontur bkontur enabled auto-merge October 7, 2024 13:10
serban300
serban300 reviewed Oct 7, 2024
View reviewed changes
bridges/relays/lib-substrate-relay/src/cli/relay_messages.rs
target_client: &impl Client<Self::Target>,
enable_version_guard: bool,
) -> relay_substrate_client::Result<()> {
if enable_version_guard {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the enable_version_guard: bool and move the if outside of the function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it could be all simplified, I have TODO for that here: #5923,
we have three copies of this exact function

@bkontur bkontur added this pull request to the merge queue Oct 7, 2024
Merged via the queue into master with commit 5778b45 Oct 7, 2024
208 of 210 checks passed
@bkontur bkontur deleted the bko-relayer-nits branch October 7, 2024 15:32
@bkontur bkontur mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@serban300 serban300 serban300 approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T15-bridges This PR/Issue is related to bridges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkontur @serban300 @acatangiu