-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bridge relayer backwards compatibility for reading storage InboundLaneData/OutboundLaneData #5921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eData/OutboundLaneData
bkontur
added
R0-silent
Changes should not be mentioned in any release notes
T15-bridges
This PR/Issue is related to bridges.
labels
Oct 4, 2024
acatangiu
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please open an issue to remove this once we fully migrate, I want us to shed unnecessary complexity
serban300
reviewed
Oct 4, 2024
serban300
approved these changes
Oct 4, 2024
2 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
R0-silent
Changes should not be mentioned in any release notes
T15-bridges
This PR/Issue is related to bridges.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For permissionless lanes, we add
lane_state
to theInboundLaneData
andOutboundLaneData
structs. However, for a period of time (until both BHK and BHP are upgraded to the same version), we need the relayer to function with runtimes where one has been migrated withlane_state
and the other has not. This PR addresses the incompatibility by introducing wrapper structs for decoding withoutlane_state
.