[1.12.0 backport] Use polkadot-ckb-merkle-mountain-range dependency
#5897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the MMR library to `polkadot-ckb-merkle-mountain-range` and pin it to version 0.7.0 to fix missing dependency issue caused by it being pinned to the `master` branch where the package has been renamed.
bkchr
approved these changes
Oct 6, 2024
|
The CI pipeline was cancelled due to failure one of the required jobs. |
serban300
approved these changes
Oct 7, 2024
acatangiu
merged commit ab7838d
into
paritytech:release-polkadot-v1.12.0
66 of 111 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Polkadot SDK v1.12.0
mmr-libdependency of thesp-mmr-primitivescrate is set to the packageckb-merkle-mountain-rangeand pinned to the master branch of this repo. The package name in that branch has changed topolkadot-ckb-merkle-mountain-range, which causes v1.12.0 to not compile.This PR does a simple backport to utilize the
polkadot-ckb-merkle-mountain-rangepublished package instead, and pins it to version 0.7.0, as was done in #4562