Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

candidate-validation: RFC103 implementation #5847

Merged
merged 164 commits into from
Oct 31, 2024
Merged

candidate-validation: RFC103 implementation #5847

merged 164 commits into from
Oct 31, 2024

Conversation

sandreim
Copy link
Contributor

Part of #5047
On top of #5679

@sandreim
WIP primitives
793142e 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
WIP
3a29fdf 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Working version.
4a53577 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Better version
8285ae7 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Add missing primitives and fix things
2831c5e 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Implement v2 receipts in polkadot-runtime-parachains
c767d60 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
add missing stuff
96999e3 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Switch parachains runtime to use new primitives
c5f2dc3 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
use vstaging primitives
dbb0160 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
update rococo and westend
5efab68 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
client keeps using the old primitives
c2232e4 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
no unsafe pls
87b079f 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
move async backing primtiives to own file
00e8c13 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix
cd4d02f 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix test build
5509e33 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix test-runtime
f8b86d2 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
self review feedback
fe2fbfb 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
review feedback
975e13b 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
feedback
1c7ac55 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
feedback
653873b 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
clippy
dc98149 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
chores
0a6bce3 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Filter v2 candidate descriptors
5e4dac2 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix
f12ca7a 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix prospective parachains tests
13734de 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix fix
effb1cc 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fmt
3f75cba 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix comment
75a47bb 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
another one
12ed853 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix build
f2c0882 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix build again
9c5097d 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Merge branch 'sandreim/node_v2_descriptors' of github.com:paritytech/…
abfd836 
…polkadot-sdk into sandreim/node_rfc103_part_1

Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Merge branch 'sandreim/node_rfc103_part_1' of github.com:paritytech/p…
669662f 
…olkadot-sdk into sandreim/node_rfc103_part_1
@sandreim
fix test
b2818f3 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix example
f647249 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fmt
82da09a 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Merge branch 'sandreim/node_v2_descriptors' of github.com:paritytech/…
db77530 
…polkadot-sdk into sandreim/node_rfc103_part_1

Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
review
36ef936 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
update bumps
2ac194f 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix audience
7a025fe 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim sandreim marked this pull request as ready for review October 24, 2024 20:34
@sandreim sandreim added T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels Oct 24, 2024
@sandreim
taplo format
d89517e 
Signed-off-by: Andrei Sandu <[email protected]>
Base automatically changed from sandreim/node_v2_descriptors to master October 25, 2024 16:12
Overkillus
Overkillus reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@Overkillus Overkillus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall logic looking good and in adherance to RFC103.

I am only catching up on all prior RFC103 PRs so I left some remarks on the old logic which was relevant for this PR.

Minor catches here and there and some open questions we can discuss or you can help me understand the context of.

polkadot/node/core/candidate-validation/src/lib.rs Outdated Show resolved Hide resolved
polkadot/node/core/candidate-validation/src/lib.rs Outdated Show resolved Hide resolved
polkadot/node/core/candidate-validation/src/lib.rs Outdated Show resolved Hide resolved
polkadot/node/core/candidate-validation/src/lib.rs Show resolved Hide resolved
polkadot/node/core/candidate-validation/src/lib.rs Show resolved Hide resolved
polkadot/node/core/candidate-validation/src/lib.rs Show resolved Hide resolved
polkadot/node/core/candidate-validation/src/lib.rs Show resolved Hide resolved
prdoc/pr_5847.prdoc Outdated Show resolved Hide resolved
polkadot/node/core/candidate-validation/src/lib.rs Outdated Show resolved Hide resolved
@sandreim
feedback
67e0dc7 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
more feedback
b696eaa 
Signed-off-by: Andrei Sandu <[email protected]>
alindima
alindima reviewed Oct 31, 2024
View reviewed changes
prdoc/pr_5847.prdoc Outdated Show resolved Hide resolved
@sandreim
update prdoc
9f12e39 
Signed-off-by: Andrei Sandu <[email protected]>
Overkillus
Overkillus approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@Overkillus Overkillus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sandreim sandreim added this pull request to the merge queue Oct 31, 2024
Merged via the queue into master with commit 2700dbf Oct 31, 2024
199 of 200 checks passed
@sandreim sandreim deleted the sandreim/node_rfc103_part_1 branch October 31, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alindima alindima alindima approved these changes

@Overkillus Overkillus Overkillus approved these changes

Assignees
No one assigned
Labels
T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
parachains team board
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sandreim @alindima @Overkillus @actions-user