Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-establish pallet_revive weights baseline #5845

Merged
merged 19 commits into from
Oct 3, 2024
Merged

Conversation

mordamax
Copy link
Contributor

@mordamax mordamax commented Sep 26, 2024

  • update baseline for pallet_revive
  • update cmd pipeline name
  • Fix compilation after renaming some of benchmarks in pallet_revive. [Runtime Dev]. Changed the "instr" benchmark so that it should no longer return to little weight. It is still bogus but at least benchmarking should not work. (by @athei )

@mordamax mordamax marked this pull request as ready for review September 26, 2024 14:47
@mordamax mordamax requested review from a team as code owners September 26, 2024 14:47
@mordamax mordamax added the R0-silent Changes should not be mentioned in any release notes label Sep 26, 2024
@athei
Copy link
Member

athei commented Sep 27, 2024

It doesn't compile because we renamed some benchmarks but never fixed the places where the benchmarks were used. The benchmarking worked fine I guess just need some follow up fixes here.

I can push the fixes to this PR later.

@athei
Copy link
Member

athei commented Sep 27, 2024

So I fixed the compilation. But because the instr benchmark is so whacky it foes down to zero and we and up with divide by zero panics. Have to look into this later.

@athei
Copy link
Member

athei commented Sep 28, 2024

/cmd bench --pallet=pallet_revive --runtime=dev

@athei
Copy link
Member

athei commented Sep 28, 2024

I changed the instr benchmark so that it should no longer return to little weight. It is still bogus but at leats benchmarking should not work.

@github-actions github-actions bot deleted a comment from mordamax Sep 28, 2024
@github-actions github-actions bot deleted a comment from mordamax Sep 28, 2024
@athei
Copy link
Member

athei commented Sep 30, 2024

Do you know why it didn't work?

.github/workflows/cmd-tests.yml Outdated Show resolved Hide resolved
@mordamax
Copy link
Contributor Author

mordamax commented Sep 30, 2024

Do you know why it didn't work?

2024-09-28T12:33:05.093879Z  WARN frame_omni_bencher: The FRAME omni-bencher is not yet battle tested - double check the results.    
2024-09-28T12:33:05.094321Z  INFO frame_benchmarking_cli::pallet::command: Loading WASM from target/release/wbuild/kitchensink-runtime/kitchensink_runtime.wasm    
2024-09-28T12:33:10.291775Z ERROR frame_benchmarking_cli::pallet::command: Please pick one of the available presets with `--genesis-builder-preset=<PRESET>`. Available presets (0): []. Error: "The preset with name Some(\"development\") is not available."    
Error: Input("The preset with name Some(\"development\") is not available.")

investigating...

@mordamax
Copy link
Contributor Author

/cmd bench --pallet=pallet_revive --runtime=dev --clean

@github-actions github-actions bot deleted a comment from mordamax Sep 30, 2024
@github-actions github-actions bot deleted a comment from mordamax Sep 30, 2024
Copy link

Command "bench --pallet=pallet_revive --runtime=dev --clean" has started 🚀 See logs here

Copy link

Command "bench --pallet=pallet_revive --runtime=dev --clean" has started 🚀 See logs here

Copy link

Command "bench --pallet=pallet_revive --runtime=dev --clean" has failed ❌! See logs here

@paritytech paritytech deleted a comment from command-bot bot Oct 1, 2024
@mordamax
Copy link
Contributor Author

mordamax commented Oct 1, 2024

bot bench substrate-pallet --pallet=pallet_revive

@command-bot
Copy link

command-bot bot commented Oct 1, 2024

@mordamax https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7477550 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_revive. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-bd6f18d0-4fc7-4f2e-940c-2310663c6b44 to cancel this command or bot cancel to cancel all commands in this pull request.

@mordamax mordamax requested a review from alvicsam October 1, 2024 22:20
…=dev --target_dir=substrate --features=riscv --pallet=pallet_revive
@command-bot
Copy link

command-bot bot commented Oct 1, 2024

@mordamax Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_revive has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7477550 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7477550/artifacts/download.

@mordamax mordamax added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@athei
Copy link
Member

athei commented Oct 2, 2024

Why are those flaky tests required again? It is really starting to get annoying.

@athei athei added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@athei athei enabled auto-merge October 2, 2024 12:08
@athei athei added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@mordamax mordamax added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@mordamax mordamax enabled auto-merge October 3, 2024 06:02
@mordamax mordamax added this pull request to the merge queue Oct 3, 2024
Merged via the queue into master with commit 72309bd Oct 3, 2024
216 of 217 checks passed
@mordamax mordamax deleted the mak-revive-baseline branch October 3, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants