[pallet-revive] Add chain ID to config an runtime API #5807

xermicus · 2024-09-23T09:39:45Z

This PR adds the EVM chain ID to Config as well as a corresponding runtime API so contracts can query it.

Signed-off-by: xermicus <[email protected]>

xermicus · 2024-09-23T09:39:53Z

bot fmt

command-bot · 2024-09-23T09:39:58Z

@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7408786 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-24908ac9-45b8-4123-a584-f2f8f559f943 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-09-23T09:41:31Z

@xermicus Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7408786 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7408786/artifacts/download.

Signed-off-by: xermicus <[email protected]>

athei · 2024-09-23T09:52:14Z

substrate/frame/revive/src/lib.rs

+		/// This is a unique identifier assigned to each blockchain network,
+		/// preventing replay attacks.
+		#[pallet::constant]
+		type ChainId: Get<u64>;


Why not U256 if that is the native format of the ID?

People seem to generally pick them within the bounds of 64bits. I guess they want to have easily readable for humans? Also there is no ConstU256 yet. But it this be fine, I hope humanity never needs more than 2**64 blockchains :P

Ah I have the same patch in my branch I used u32, there..., both are fine I guess

Ok let's stick with u64. As long as we don't need to convert back to u64 it's fine.

On the RPC side I'm not sure but for the runtime I don't see where we would need to parse this ever.

However even if so, I feel like this would need to be a fallible conversion anyways (you can parse any U256 but if you want it to match against the configured chain ID, if the U256 is > u64::MAX you know that the chain ID would not match anyways).

pgherveou · 2024-09-23T10:18:03Z

substrate/frame/revive/src/lib.rs

@@ -365,6 +372,7 @@ pub mod pallet {
 			type Xcm = ();
 			type RuntimeMemory = ConstU32<{ 128 * 1024 * 1024 }>;
 			type PVFMemory = ConstU32<{ 512 * 1024 * 1024 }>;
+			type ChainId = ConstU64<{ 0 }>;


You mind setting it to 42 here, I need to reconfigure my Metamask extension otherwise 🙃

What do you mean by extension? Shouldn't Metamask just use an RPC to query to chain id?

Also this ChainId is not really used. It is just the default derive that can be used for tests. But it is overriden in tests.

if you configure a local network with metamask, you need to specify the chain_id, you can update it later on, but from what I experienced there is a bug and it still use the old value, so you delete your custom network and recreate it.

42 is already taken and I thought this should either be zero or something that's not taken yet? (Something that's not taken yet could however get taken later on). WDYT?

sounds good then, I just need to remember to change this once I rebase on top of this

athei · 2024-09-23T10:24:31Z

substrate/frame/revive/src/wasm/runtime.rs

+	/// Returns the chain ID.
+	/// See [`pallet_revive_uapi::HostFn::chain_id`].
+	#[api_version(0)]
+	fn chain_id(&mut self, memory: &mut M, out_ptr: u32) -> Result<(), TrapReason> {
+		Ok(self.write_fixed_sandbox_output(


Doesn't charge any gas except the syscall overhead. Needs a benchmark.

Ah yes good catch. Since this doesn't really do anything except writing a constant to contract memory and the syscall overhead is apparently already charged, would the RuntimeCosts::CopyToContract(len) do it instead of a dedicated benchmark?

Yes this should be fine. However, we need to remember to make our seal_input benchmark better (where this weight is based in). Right now it just does a memory copy. Which is probably fair with in-runtime PolkaVM but with a JIT there will be some constant overhead for a copy.

There are probably also many other "getters" which don't access storage that could be refactored this way.

Yeah right I see. Just added the gas token for now, thanks!

Signed-off-by: xermicus <[email protected]>

xermicus · 2024-09-23T13:51:23Z

bot fmt

command-bot · 2024-09-23T13:51:30Z

@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7411720 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-0bf5f027-c0fd-4775-b58d-82848faa6d5b to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-09-23T13:53:02Z

@xermicus Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7411720 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7411720/artifacts/download.

xermicus added 2 commits September 23, 2024 11:35

add chain id to config and expose via syscall

708bd81

Signed-off-by: xermicus <[email protected]>

Merge branch 'master' into cl/chain_id

17e5dfa

xermicus added R0-silent Changes should not be mentioned in any release notes T7-smart_contracts This PR/Issue is related to smart contracts. labels Sep 23, 2024

xermicus requested review from pgherveou and athei September 23, 2024 09:39

".git/.scripts/commands/fmt/fmt.sh"

d1f70d2

xermicus added 2 commits September 23, 2024 11:43

prdoc

e016926

Signed-off-by: xermicus <[email protected]>

impor

83b6426

Signed-off-by: xermicus <[email protected]>

athei reviewed Sep 23, 2024

View reviewed changes

pgherveou reviewed Sep 23, 2024

View reviewed changes

pgherveou approved these changes Sep 23, 2024

View reviewed changes

athei requested changes Sep 23, 2024

View reviewed changes

xermicus added 2 commits September 23, 2024 12:37

gas token

8289a48

Signed-off-by: xermicus <[email protected]>

configure chainid in the ktichensink runtime

32b4b0a

Signed-off-by: xermicus <[email protected]>

xermicus requested a review from athei September 23, 2024 12:57

athei approved these changes Sep 23, 2024

View reviewed changes

xermicus enabled auto-merge September 23, 2024 13:46

".git/.scripts/commands/fmt/fmt.sh"

ae1b232

xermicus added this pull request to the merge queue Sep 23, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 23, 2024

Merge branch 'master' into cl/chain_id

2eb574b

xermicus enabled auto-merge September 23, 2024 16:50

xermicus added this pull request to the merge queue Sep 23, 2024

Merged via the queue into master with commit 71c768a Sep 23, 2024
206 of 209 checks passed

xermicus deleted the cl/chain_id branch September 23, 2024 18:02

athei mentioned this pull request Nov 28, 2024

pallet_revive launch tracking issue paritytech/contract-issues#13

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pallet-revive] Add chain ID to config an runtime API #5807

[pallet-revive] Add chain ID to config an runtime API #5807

xermicus commented Sep 23, 2024

xermicus commented Sep 23, 2024

command-bot bot commented Sep 23, 2024 •

edited

Loading

command-bot bot commented Sep 23, 2024

athei Sep 23, 2024

xermicus Sep 23, 2024

pgherveou Sep 23, 2024

athei Sep 23, 2024

xermicus Sep 23, 2024 •

edited

Loading

xermicus Sep 23, 2024 •

edited

Loading

pgherveou Sep 23, 2024

athei Sep 23, 2024 •

edited

Loading

athei Sep 23, 2024

pgherveou Sep 23, 2024

xermicus Sep 23, 2024

pgherveou Sep 23, 2024

athei Sep 23, 2024

xermicus Sep 23, 2024

athei Sep 23, 2024

xermicus Sep 23, 2024

xermicus commented Sep 23, 2024

command-bot bot commented Sep 23, 2024 •

edited

Loading

command-bot bot commented Sep 23, 2024

[pallet-revive] Add chain ID to config an runtime API #5807

[pallet-revive] Add chain ID to config an runtime API #5807

Conversation

xermicus commented Sep 23, 2024

xermicus commented Sep 23, 2024

command-bot bot commented Sep 23, 2024 • edited Loading

command-bot bot commented Sep 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xermicus Sep 23, 2024 • edited Loading

Choose a reason for hiding this comment

xermicus Sep 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

athei Sep 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xermicus commented Sep 23, 2024

command-bot bot commented Sep 23, 2024 • edited Loading

command-bot bot commented Sep 23, 2024

command-bot bot commented Sep 23, 2024 •

edited

Loading

xermicus Sep 23, 2024 •

edited

Loading

xermicus Sep 23, 2024 •

edited

Loading

athei Sep 23, 2024 •

edited

Loading

command-bot bot commented Sep 23, 2024 •

edited

Loading