Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fast return for invalid request of node health #5762

Merged
merged 3 commits into from
Sep 19, 2024
Merged

chore: fast return for invalid request of node health #5762

merged 3 commits into from
Sep 19, 2024

Conversation

yjhmelody
Copy link
Contributor

No description provided.

bkchr
bkchr approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a prdoc

substrate/client/rpc-servers/src/middleware/node_health.rs Show resolved Hide resolved
@bkchr bkchr requested a review from niklasad1 September 19, 2024 07:12
@bkchr bkchr added the T0-node This PR/Issue is related to the topic “node”. label Sep 19, 2024
@niklasad1
Copy link
Member

bot fmt

@command-bot
Copy link

command-bot bot commented Sep 19, 2024 •
edited
Loading

@niklasad1 https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7383759 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-84ceb2be-e392-4a4e-a9bf-03ce1fd15d12 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Sep 19, 2024

@niklasad1 Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7383759 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7383759/artifacts/download.

@niklasad1 niklasad1 added this pull request to the merge queue Sep 19, 2024
Merged via the queue into paritytech:master with commit d31bb8a Sep 19, 2024
201 of 208 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yjhmelody @niklasad1 @bkchr