revive: Make salt salt optional to allow for CREATE1 semantics
#5556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgherveou
approved these changes
Sep 3, 2024
athei
changed the title
salt salt optional to allow for CREATE1 semanticssalt salt optional to allow for CREATE1 semantics
xermicus
approved these changes
Sep 3, 2024
|
Setting the silent label before we reach 1.0. Otherwise we will spam the changelog with a lot of useless messages before the pallet is even useable. prdoc is still necessary so that the pallet version can be bumped and released. |
athei
changed the title
salt salt optional to allow for CREATE1 semanticssalt salt optional to allow for CREATE1 semantics
x3c41a
pushed a commit
that referenced
this pull request
Sep 4, 2024
Before we only supported CREATE2 semantics for contract address derivations. In order to be compatible we also want to allow CREATE1 semantics. We accomplish this to make the salt an `Option` in all places where it is used. Supplying `None` will use CREATE1 semantics by just using the deployers account nonce. ## Todo - [x] Add new tests specific for CREATE1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we only supported CREATE2 semantics for contract address derivations. In order to be compatible we also want to allow CREATE1 semantics. We accomplish this to make the salt an
Optionin all places where it is used. SupplyingNonewill use CREATE1 semantics by just using the deployers account nonce.Todo