Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid updating the block gap when it's unchanged #5540

Merged
merged 5 commits into from
Sep 4, 2024
+82 −86
Merged

Avoid updating the block gap when it's unchanged #5540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bde7609
Avoid updating the block gap when it's unchanged
liuchengxu Sep 1, 2024
f2a260b
Make format strings more consistent within this file
liuchengxu Sep 1, 2024
e977dd5
Only update the block gap state when it's changed
liuchengxu Sep 1, 2024
335ac51
Add prdoc
liuchengxu Sep 1, 2024
79c5e6f
Merge branch 'master' into avoid-updating-block-gap-when-unchanged
davxy Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions prdoc/pr_5540.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
title: Avoid unnecessary block gap updates

doc:
- audience: Node Dev
description: |
Previously, the block gap storage in database and state in `BlockchainDb` could be updated even if no changes occurred.
This commit refines the logic to ensure updates only occur when the block gap value actually changes, reducing unnecessary
writes and enhancing overall efficiency.

crates:
- name: sc-client-db
bump: none
Loading
Loading