Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PendingConfigs storage item public #5467

Merged

Conversation

ParthDesai
Copy link
Contributor

Description

This PR changes PendingConfigs storage item's visibility from crate to public. This enable us to read it in our runtime.

@bkchr bkchr added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Aug 27, 2024
@bkchr
Copy link
Member

bkchr commented Aug 27, 2024

@ParthDesai please add a prdoc.

@ParthDesai
Copy link
Contributor Author

@ParthDesai please add a prdoc.

Done.

prdoc/pr_5467.prdoc Outdated Show resolved Hide resolved
@bkchr bkchr enabled auto-merge August 27, 2024 14:36
@bkchr bkchr added this pull request to the merge queue Aug 27, 2024
Merged via the queue into paritytech:master with commit 0d7becf Aug 27, 2024
183 of 189 checks passed
@ParthDesai ParthDesai deleted the make-pending-config-storage-public branch August 28, 2024 05:27
ordian added a commit that referenced this pull request Aug 29, 2024
* master: (39 commits)
  short-term fix for para inherent weight overestimation (#5082)
  CI: Add backporting bot (#4795)
  Fix benchmark failures when using `insecure_zero_ed` flag (#5354)
  Command bot GHA v2 - /cmd <cmd> (#5457)
  Remove pallet::getter usage from treasury (#4962)
  Bump blake2b_simd from 1.0.1 to 1.0.2 (#5404)
  Bump rustversion from 1.0.14 to 1.0.17 (#5405)
  Bridge zombienet tests: remove old command (#5434)
  polkadot-parachain: Add omni-node variant with u64 block number (#5269)
  Refactor verbose test (#5506)
  Use umbrella crate for minimal template (#5155)
  IBP Coretime Polkadot bootnodes (#5499)
  rpc server: listen to `ipv6 socket` if available and `--experimental-rpc-endpoint` CLI option (#4792)
  Update approval-voting-regression-bench (#5504)
  change try-runtime rpc domains (#5443)
  polkadot-parachain-bin: Remove contracts parachain (#5471)
  Add feature to allow Aura collator to use full PoV size (#5393)
  Adding stkd bootnodes (#5470)
  Make `PendingConfigs` storage item public (#5467)
  frame-omni-bencher maintenance (#5466)
  ...
ParthDesai added a commit to moondance-labs/polkadot-sdk that referenced this pull request Aug 30, 2024
## Description
This PR changes `PendingConfigs` storage item's visibility from crate to
public. This enable us to read it in our runtime.

---------

Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants