Remove staking controller account logic from pallets & runtimes #5449
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes controller logic from pallets & chain specs. Tracking issue: #2500
Prerequisites before merging
This PR should be merged once the following tasks have been completed:
restore_ledger
has been executed on Polkadot, that fixes corrupt ledger state items. Polkadot Forum tracking thread hereupdate_payee
has been executed on Polkadot, migrating allRewardDestination::Controller
entries toRewardDestination::Account(controller)
entries.deprecate_controller_batch
calls have been executed on Kusama and Polkadot, that updates all unique controllers to the corresponding stash address.Once these prerequisites have been completed, it will be safe to bump the staking pallet with the updates of this PR.
Pre-merge checklist
staking
benchmarks.Controller deprecation
deprecate_controller_batch
call from staking pallet andMaxControllersInDeprecationBatch
across codebase.set_controller
call from staking pallet.staking
calls that requirecontroller
as origin to bestash
instead.update_payee
call from staking pallet.maybe_controller
param fromrestore_ledger
.testing_utils
to not provide controller accounts.fast-unstake
calls that requirecontroller
as origin to bestash
instead.Bonded
storage.StakingAccount::Controller
from staking ledger.Bonded
storage.