Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving cargo check for runtimes to GHA #5340

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Moving cargo check for runtimes to GHA #5340

merged 1 commit into from
Aug 15, 2024

Conversation

mutantcornholio
Copy link
Contributor

@mutantcornholio mutantcornholio commented Aug 13, 2024 •
edited
Loading

@mutantcornholio mutantcornholio requested review from a team as code owners August 13, 2024 10:33
@mutantcornholio mutantcornholio marked this pull request as draft August 13, 2024 10:33
@mutantcornholio mutantcornholio force-pushed the yuri/cargo-checks-gha branch 8 times, most recently from e8462f0 to 2d24d75 Compare August 14, 2024 15:59
@mutantcornholio mutantcornholio added R0-silent Changes should not be mentioned in any release notes GHA-migration Temporary label for migrating CI to GHA labels Aug 14, 2024
@mutantcornholio mutantcornholio force-pushed the yuri/cargo-checks-gha branch 3 times, most recently from 5fce768 to bc823dc Compare August 14, 2024 16:35
@mutantcornholio mutantcornholio changed the title [WIP] Moving cargo check for runtimes to GHA Moving cargo check for runtimes to GHA Aug 14, 2024
@mutantcornholio mutantcornholio marked this pull request as ready for review August 14, 2024 16:40
@paritytech-review-bot paritytech-review-bot bot requested a review from a team August 14, 2024 16:46
@paritytech-review-bot paritytech-review-bot bot requested a review from a team August 14, 2024 17:08
alvicsam
alvicsam requested changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@alvicsam alvicsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Small addition is still required (timeouts) and also I'd add a final job that depends on all other jobs (like here) in case we decide to mark these jobs Required in the future.

@paritytech-review-bot paritytech-review-bot bot requested a review from a team August 15, 2024 09:26
@paritytech-review-bot paritytech-review-bot bot requested a review from a team August 15, 2024 09:43
@mutantcornholio mutantcornholio removed the GHA-migration Temporary label for migrating CI to GHA label Aug 15, 2024
@mutantcornholio mutantcornholio added this pull request to the merge queue Aug 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 15, 2024
@mutantcornholio
Moving cargo check for runtimes to GHA (#5340)
caee1a2 
Fixes paritytech/ci_cd#1015
Merged via the queue into master with commit 41a679c Aug 15, 2024
180 of 186 checks passed
@mutantcornholio mutantcornholio deleted the yuri/cargo-checks-gha branch August 15, 2024 17:34
ordian added a commit that referenced this pull request Aug 16, 2024
@ordian
Merge branch 'master' into ao-fix-backing-filtering-on-disputes
6563fe2 
* master:
  Remove redundant minimal template workspace (#5330)
  approval-distribution: Fix handling of conclude (#5375)
  More logs in `is_potential_spam` from `dispute-coordinator` (#5252)
  Fix zombienet bridges test (#5373)
  Update Readme of the `polkadot` crate (#5326)
  allow for `u8` to be used as hold/freeze reason (#5348)
  Moving cargo check for runtimes to GHA (#5340)
  Update links in the documentation (#5175)
  fix visibility for `pallet_nfts` types used as call arguments (#3634)
  Correct some typos in crates' descriptions (#5262)
  Aura: Ensure we are building on each relay chain fork (#5352)
  Update Identity pallet README.md (#5183)
  Bump trie-db from 0.29.0 to 0.29.1 (#5231)
  [Coretime] Always include UnpaidExecution, not just when revenue is > 0 (#5369)
  [Pools] fix derivation of pool account (#4999)
ordian added a commit that referenced this pull request Aug 16, 2024
@ordian
Merge branch 'master' into ao-fix-parainclusion-weight-overestimation
277f40a 
* master:
  Remove redundant minimal template workspace (#5330)
  approval-distribution: Fix handling of conclude (#5375)
  More logs in `is_potential_spam` from `dispute-coordinator` (#5252)
  Fix zombienet bridges test (#5373)
  Update Readme of the `polkadot` crate (#5326)
  allow for `u8` to be used as hold/freeze reason (#5348)
  Moving cargo check for runtimes to GHA (#5340)
  Update links in the documentation (#5175)
  fix visibility for `pallet_nfts` types used as call arguments (#3634)
  Correct some typos in crates' descriptions (#5262)
  Aura: Ensure we are building on each relay chain fork (#5352)
  Update Identity pallet README.md (#5183)
  Bump trie-db from 0.29.0 to 0.29.1 (#5231)
  [Coretime] Always include UnpaidExecution, not just when revenue is > 0 (#5369)
  [Pools] fix derivation of pool account (#4999)
  Upgrade accidentally downgraded deps (#5365)
  [Pools] Fix issues with member migration to `DelegateStake` (#4822)
  Unify `no_genesis` check (#5360)
  [CI] Fix prdoc command (#5358)
  Beefy: add benchmarks for `report_fork_voting()` (#5188)
ordian added a commit that referenced this pull request Aug 16, 2024
@ordian
Merge branch 'ao-fix-parainclusion-weight-overestimation' into ao-ena…
df57a53 
…ct-candidate-weight

* ao-fix-parainclusion-weight-overestimation:
  Remove redundant minimal template workspace (#5330)
  approval-distribution: Fix handling of conclude (#5375)
  More logs in `is_potential_spam` from `dispute-coordinator` (#5252)
  Fix zombienet bridges test (#5373)
  Update Readme of the `polkadot` crate (#5326)
  allow for `u8` to be used as hold/freeze reason (#5348)
  Moving cargo check for runtimes to GHA (#5340)
  Update links in the documentation (#5175)
  fix visibility for `pallet_nfts` types used as call arguments (#3634)
  Correct some typos in crates' descriptions (#5262)
  Aura: Ensure we are building on each relay chain fork (#5352)
  Update Identity pallet README.md (#5183)
  Bump trie-db from 0.29.0 to 0.29.1 (#5231)
  [Coretime] Always include UnpaidExecution, not just when revenue is > 0 (#5369)
  [Pools] fix derivation of pool account (#4999)
  Upgrade accidentally downgraded deps (#5365)
  [Pools] Fix issues with member migration to `DelegateStake` (#4822)
  Unify `no_genesis` check (#5360)
  [CI] Fix prdoc command (#5358)
  Beefy: add benchmarks for `report_fork_voting()` (#5188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorPopelyaev EgorPopelyaev EgorPopelyaev left review comments

@mordamax mordamax mordamax approved these changes

@alvicsam alvicsam alvicsam approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mutantcornholio @mordamax @EgorPopelyaev @alvicsam