Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata V16 (unstable): Enrich metadata with associated types of config traits #5274
Metadata V16 (unstable): Enrich metadata with associated types of config traits #5274
Changes from 44 commits
7e8baee
1c12f15
20b22d8
350efce
3e97971
5d8021e
5679244
958611e
7f26b67
cc001f3
b2803e2
94007d8
75d2697
ebcb4a0
5115021
aba029a
6502c83
e9571cb
31bf284
7429eb7
8a0c138
c6c1800
90c100c
2982c59
f703e4d
fbd36bc
6be9ef3
c9b0e2a
0382d32
e52ba1d
45f86eb
fb8b2d4
4846726
d4e597d
a453595
8b9549d
cf6749b
54e6d2a
610bdc2
b18a2f9
678944a
d43743c
0928d78
8fd0180
ac08308
1296dc2
c1f204f
bc0f528
b125a1e
39a9d4b
ac92bc6
e96b36d
e91da23
f3e3e1e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Why not a Set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd need some feature similar to rust-lang/rust#93140 to make the hashSet const here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this will not match
scale::TypeInfo
but onlyTypeInfo
, isn't it?What I mean is that we do the match on the whole path, not the last segment, no?
If we want to support only this. Then we can say in the error message of
include_metadata
something like: "Note: only ident is supported, e.g.scale::TypeInfo
is not detected, onlyTypeInfo
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should just take the last element of the path to improve the detection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be an error if the attribute is passed multiple times.