rpc: Enable ChainSpec for polkadot-parachain #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
lexnv
added
I5-enhancement
Signed-off-by: Alexandru Vasile <[email protected]>
dmitry-markin
approved these changes
Aug 1, 2024
This reverts commit 2675d44.
skunert
reviewed
Aug 1, 2024
| @@ -281,12 +282,13 @@ pub(crate) trait NodeSpec { | |||
| let transaction_pool = transaction_pool.clone(); | |||
| let backend_for_rpc = backend.clone(); | |||
|
|
|||
| Box::new(move |deny_unsafe, _| { | |||
| Box::new(move |deny_unsafe: sc_rpc::DenyUnsafe, _| { | |||
There was a problem hiding this comment.
Why is the type needed now in contrast to before?
There was a problem hiding this comment.
I think I've hit the autocomplete by mistake :D No longer needed since I was able to obtain the same by moving the initialization to the substrate builder
skunert
approved these changes
Aug 1, 2024
This reverts commit cc90001. Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
lexnv
changed the title
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: Alexandru Vasile <[email protected]>
|
Testing done:
|
Signed-off-by: Alexandru Vasile <[email protected]>
|
Nice one, with this refactor now all users of polkadot-sdk gets the entire rpc v2 API without having to use their own rpc extensions for it. |
niklasad1
reviewed
Aug 1, 2024
prdoc/pr_5205.prdoc
Outdated
| - Runtime Dev | ||
| - Node Dev | ||
| description: | | ||
| Enables the `chainSpec_v1` rpc-v2 API for polkadot-parachains. |
There was a problem hiding this comment.
I would like to re-phrase this as:
The substrate-service-builder now includes the entire rpc v2 API. The chainspec API was previously defined as rpc extension where for instance chains would need to enable it explicitly for it to be enabled which isn't the case anymore
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
ordian
added a commit
that referenced
this pull request
Aug 6, 2024
* master: (51 commits) Remove unused feature gated code from the minimal template (#5237) make polkadot-parachain startup errors pretty (#5214) Coretime auto-renew (#4424) network/strategy: Backoff and ban overloaded peers to avoid submitting the same request multiple times (#5029) Fix frame crate usage doc (#5222) beefy: Tolerate pruned state on runtime API call (#5197) rpc: Enable ChainSpec for polkadot-parachain (#5205) Add an adapter for configuring AssetExchanger (#5130) Replace env_logger with sp_tracing (#5065) Adjust sync templates flow to use new release branch (#5182) litep2p/discovery: Publish authority records with external addresses only (#5176) Run UI tests in CI for some other crates (#5167) Remove `pallet::getter` usage from the pallet-balances (#4967) pallet-timestamp: `UnixTime::now` implementation logs error only if called at genesis (#5055) [CI] Cache try-runtime check (#5179) [Backport] version bumps and the prdocs reordering from stable2407 (#5178) [subsystem-benchmark] Update availability-distribution-regression-bench baseline after recent subsystem changes (#5180) Remove pallet::getter usage from proxy (#4963) Remove pallet::getter macro usage from pallet-election-provider-multi-phase (#4487) [email protected] (#5177) ...
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the
chainSpec_v1class for the polkadot-parachian.The chainSpec is part of the rpc-v2 which is spec-ed at: https://github.com/paritytech/json-rpc-interface-spec/blob/main/src/api/chainSpec.md.
This also paves the way for enabling a future
chainSpec_unstable_specon all nodes.Closes: #5191
cc @paritytech/subxt-team