Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pallet macro: Support instantiable pallets in tasks #5194
pallet macro: Support instantiable pallets in tasks #5194
Changes from 10 commits
1f22ef8
1e5e08d
db9da48
1e51725
693791b
1ba17b5
3ae8f02
407f569
4aa417d
601a222
28acc06
eb3061c
7c1487b
f5b7502
bbcc29c
e4e0d01
3118efa
af47f93
c2918e2
088b586
6ffb144
a4115ac
392431a
671913d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be the same as
type_use_generics
, if not we would have some problem. I think we should removegenerics
and just use thetype_use_generics
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a check for generics at eb3061c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR we no longer modify the
Def
to insert a generatedtask_enum
in case none were provided.Instead we just expand what we need without modifying the
Def
in the expand phase.As a result we need to use
tasks
instead oftask_enum
for generating the automatic part later.But all in all behavior is not changed