-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pub
to xcm::v4::PalletInfo
#4976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was clearly a misstep, let's backport it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a prdoc (see directory called prdoc)
@acatangiu semver check failed because it thinks the change to pub is a major and not a patch. But the pub fields were the original API. Can we override the check? |
Don't know honestly. @ggwpez @Morganamilo ? Changing this to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI seems to be wrong here - this does indeed not look like a major change to me.
Running the semver-check CLI locally confirms this.
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
ad9804f
v3 PalletInfo had the fields public, but not v4. Any reason why? I need the PalletInfo fields public so I can read the values and do some logic based on that at Polimec @franciscoaguirre If this could be backported would be highly appreciated 🙏🏻 --------- Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
v3 PalletInfo had the fields public, but not v4. Any reason why? I need the PalletInfo fields public so I can read the values and do some logic based on that at Polimec @franciscoaguirre If this could be backported would be highly appreciated 🙏🏻 --------- Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Backporting #4976 to version 1.14.0. The fields in `PalletInfo` were not `pub` in XCMv4 when they were for XCMv3. --------- Co-authored-by: Juan Ignacio Rios <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
v3 PalletInfo had the fields public, but not v4. Any reason why?
I need the PalletInfo fields public so I can read the values and do some logic based on that at Polimec
@franciscoaguirre
If this could be backported would be highly appreciated 🙏🏻