-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build options to the srtool build step #4956
Merged
bkchr
merged 24 commits into
paritytech:master
from
EgorPopelyaev:ep-add-build-opts-to-release
Aug 26, 2024
Merged
Changes from 13 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
df3922d
add runtimes build options to srtool build
EgorPopelyaev f611426
add srtool build with options
EgorPopelyaev a45ad83
add additional step to set build options
EgorPopelyaev 8b4b2f2
add qoutes
EgorPopelyaev defe4a4
change scope of BUILD_OPTIONS
EgorPopelyaev 8b08e5f
chaneg build optas and add a job to build runtimes with logging activ…
EgorPopelyaev 79d3474
add on-chain-release-build feature to where it is missing
EgorPopelyaev aca9c75
Merge branch 'master' into ep-add-build-opts-to-release
EgorPopelyaev 213574f
add upload runtiems without logging
EgorPopelyaev 1ccbc2a
change call of the env
EgorPopelyaev 6ad1e29
hardcode suffix as reusable workflow does not parse env
EgorPopelyaev 8698c39
adjust path to release-notes-context.json
EgorPopelyaev 9c02c32
Merge branch 'master' into ep-add-build-opts-to-release
bkchr 9d236b7
Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…
EgorPopelyaev 75720f7
Merge branch 'ep-add-build-opts-to-release' of https://github.com/Ego…
EgorPopelyaev cff9c73
delete `disable-logging` and adjust flow to build runtimes only one time
EgorPopelyaev 063cba0
Merge branch 'master' into ep-add-build-opts-to-release
EgorPopelyaev 26da67b
Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…
EgorPopelyaev 9942d15
Merge branch 'ep-add-build-opts-to-release' of https://github.com/Ego…
EgorPopelyaev df7bf5a
Merge branch 'master' into ep-add-build-opts-to-release
EgorPopelyaev d7cf048
Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…
EgorPopelyaev 6b9d737
Add PrDoc (auto generated)
EgorPopelyaev de219c9
Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…
EgorPopelyaev e48b99d
update prdoc
EgorPopelyaev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,10 @@ on: | |
inputs: | ||
excluded_runtimes: | ||
type: string | ||
build_opts: | ||
type: string | ||
name_suffix: | ||
type: string | ||
outputs: | ||
published_runtimes: | ||
value: ${{ jobs.find-runtimes.outputs.runtime }} | ||
|
@@ -74,6 +78,8 @@ jobs: | |
- name: Srtool build | ||
id: srtool_build | ||
uses: chevdor/[email protected] | ||
env: | ||
BUILD_OPTS: ${{ inputs.build_opts }} | ||
with: | ||
chain: ${{ matrix.chain }} | ||
runtime_dir: ${{ matrix.runtime_dir }} | ||
|
@@ -117,7 +123,7 @@ jobs: | |
- name: Archive Subwasm results | ||
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 | ||
with: | ||
name: ${{ matrix.chain }}-runtime | ||
name: ${{ matrix.chain }}-runtime${{ inputs.name_suffix }} | ||
path: | | ||
${{ matrix.chain }}-info.json | ||
${{ matrix.chain }}-compressed-info.json | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't enable the
on-chain-release-build
feature. This means that metadata hash will not be generated at compile time. This is bad 🙈There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this one was done only for the case to have the logging enabled. In theory, this step should go away if the
disable-logging
feature will be deleted from theon-chain-release-build
as we discussed above. If it is ok, I can delete it as part of this PR, and then we will have only the one build with theon-chain-release-build
feature activated.