Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fellowship-core: add fast promote #4877

Merged
merged 19 commits into from
Jun 26, 2024
Merged

Fellowship-core: add fast promote #4877

merged 19 commits into from
Jun 26, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jun 25, 2024 •
edited
Loading

Add a promote_fast extrinsic to the core-fellowship pallet to allow promotions that ignore the promotion cooldown. It comes with a new FastPromoteOrigin.

Supersedes #4778

@ggwpez
Fellowship-core: add fast promote
aeee112 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez requested a review from a team as a code owner June 25, 2024 15:51
@ggwpez
prdoc
1b67731 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
fmt
2caee87 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez added the T2-pallets This PR/Issue is related to a particular pallet. label Jun 25, 2024
acatangiu
acatangiu approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ggwpez
Make compile
d245ff5 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Make compile
7701058 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Make compile
d8bcf53 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
xlc
xlc reviewed Jun 26, 2024
View reviewed changes
substrate/frame/core-fellowship/src/lib.rs
Ok(allow_rank) => ensure!(allow_rank >= to_rank, Error::<T, I>::NoPermission),
Err(origin) => ensure_root(origin)?,
}
ensure!(to_rank as u32 <= T::MaxRank::get(), Error::<T, I>::InvalidRank);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe refactor those into a helper function so it can be shared with promote

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes could do, but it needs to go into the release today and its already approved 🫠

joepetrowski
joepetrowski approved these changes Jun 26, 2024
View reviewed changes
prdoc/pr_4877.prdoc Outdated Show resolved Hide resolved
substrate/frame/core-fellowship/src/lib.rs Outdated Show resolved Hide resolved
@ggwpez
Copy link
Member Author

ggwpez commented Jun 26, 2024

bot bench substrate-pallet --pallet=pallet-core-fellowship
bot bench cumulus-collectives --pallet=pallet-core-fellowship

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6554464

@ggwpez
Copy link
Member Author

ggwpez commented Jun 26, 2024

bot bench substrate-pallet --pallet=pallet_core_fellowship
bot bench cumulus-collectives --pallet=pallet_core_fellowship

@ggwpez
compile
e001d69 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Copy link
Member Author

ggwpez commented Jun 26, 2024

bot cancel
bot clean
bot bench substrate-pallet --pallet=pallet_core_fellowship

@command-bot
Copy link

command-bot bot commented Jun 26, 2024

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=collectives-westend --runtime_dir=collectives --target_dir=cumulus --pallet=pallet_core_fellowship has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6554912 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6554912/artifacts/download.

@command-bot
Copy link

command-bot bot commented Jun 26, 2024 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6555216 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_core_fellowship. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-90e781f1-719b-4647-95cd-6ded39473917 to cancel this command or bot cancel to cancel all commands in this pull request.

@ggwpez ggwpez added this pull request to the merge queue Jun 26, 2024
@ggwpez ggwpez removed this pull request from the merge queue due to a manual request Jun 26, 2024
@ggwpez
Prdoc
ca9713d 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez enabled auto-merge June 26, 2024 13:51
@ggwpez ggwpez added this pull request to the merge queue Jun 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 26, 2024
@ggwpez ggwpez added this pull request to the merge queue Jun 26, 2024
Merged via the queue into master with commit b4ae5b0 Jun 26, 2024
152 of 158 checks passed
@ggwpez ggwpez deleted the oty-fast-promote branch June 26, 2024 15:12
@ggwpez ggwpez mentioned this pull request Jul 1, 2024
Closed
@bkchr bkchr mentioned this pull request Jul 3, 2024
Closed
@joepetrowski joepetrowski mentioned this pull request Jul 16, 2024
Closed
9 tasks
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@ggwpez @joepetrowski @TarekkMA
Fellowship-core: add fast promote (paritytech#4877)
335dab9 
Add a `promote_fast` extrinsic to the `core-fellowship` pallet to allow
promotions that ignore the promotion cooldown. It comes with a new
`FastPromoteOrigin`.

Supersedes paritytech#4778

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: joe petrowski <[email protected]>
Co-authored-by: command-bot <>
This was referenced Aug 21, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc left review comments

@bkchr bkchr bkchr approved these changes

@seadanda seadanda seadanda approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

@acatangiu acatangiu acatangiu approved these changes

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ggwpez @paritytech-cicd-pr @xlc @bkchr @seadanda @joepetrowski @acatangiu