Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-network-types: implement From<IpAddr> for Multiaddr #4855

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

dmitry-markin
Copy link
Contributor

@dmitry-markin dmitry-markin commented Jun 21, 2024

Add From implementation used by downstream project.

Ref. #4198 (comment)

CC @nazar-pc

@dmitry-markin dmitry-markin added R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Jun 21, 2024
@dmitry-markin dmitry-markin self-assigned this Jun 21, 2024
Copy link
Contributor

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for quick patch!

@dmitry-markin dmitry-markin added this pull request to the merge queue Jun 21, 2024
Merged via the queue into master with commit 3b3a1d2 Jun 21, 2024
168 of 169 checks passed
@dmitry-markin dmitry-markin deleted the dm-from-ipaddr-multiaddr branch June 21, 2024 15:13
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”.
Projects
Status: Blocked ⛔️
Development

Successfully merging this pull request may close these issues.

4 participants