Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getter macro from pallet-insecure-randomness-collective-flip #4839

Conversation

PolkadotDom
Copy link
Contributor

@PolkadotDom PolkadotDom commented Jun 19, 2024

As per #3326, removes pallet::getter macro usage from the pallet-insecure-randomness-collective-flip. The syntax StorageItem::<T, I>::get() should be used instead.

Explicitly implements the getters that were removed as well, following #223

Also makes the storage values public and converts some syntax to turbo

cc @muraca

@PolkadotDom PolkadotDom requested a review from a team as a code owner June 19, 2024 19:13
@paritytech-review-bot paritytech-review-bot bot requested a review from a team June 22, 2024 18:08
@PolkadotDom PolkadotDom requested a review from ggwpez June 22, 2024 18:40
@ggwpez ggwpez added the T2-pallets This PR/Issue is related to a particular pallet. label Jul 3, 2024
prdoc/pr_4839.prdoc Outdated Show resolved Hide resolved
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
@bkchr bkchr enabled auto-merge July 3, 2024 20:27
@bkchr bkchr added this pull request to the merge queue Jul 3, 2024
Merged via the queue into paritytech:master with commit 924728c Jul 3, 2024
154 of 158 checks passed
skunert added a commit to skunert/polkadot-sdk that referenced this pull request Jul 4, 2024
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request Jul 7, 2024
…aritytech#4839)

As per paritytech#3326, removes pallet::getter macro usage from the
pallet-insecure-randomness-collective-flip. The syntax `StorageItem::<T,
I>::get()` should be used instead.

Explicitly implements the getters that were removed as well, following
paritytech#223

Also makes the storage values public and converts some syntax to turbo

cc @muraca

---------

Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
…aritytech#4839)

As per paritytech#3326, removes pallet::getter macro usage from the
pallet-insecure-randomness-collective-flip. The syntax `StorageItem::<T,
I>::get()` should be used instead.

Explicitly implements the getters that were removed as well, following
paritytech#223

Also makes the storage values public and converts some syntax to turbo

cc @muraca

---------

Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants