rpc server: add health/readiness endpoint
#4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
changed the title
bkchr
approved these changes
Jun 17, 2024
prdoc/pr_4802.prdoc
Outdated
| doc: | ||
| - audience: Node Operator | ||
| description: | | ||
| Add health readiness endpoint to the rpc server |
There was a problem hiding this comment.
Would be nice to mention the path to poll this?
Comment on lines
184
to
185
| "/health" if req.method() == http::Method::GET => InterceptRequest::Health, | ||
| "/health/readiness" if req.method() == http::Method::GET => InterceptRequest::Readiness, |
There was a problem hiding this comment.
Maybe could return an error if method() is not Get?
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
|
Sorry I fucked up a merge commit and I had to rebase |
niklasad1
changed the title
health/readiness endpoint
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Previous attempt paritytech/substrate#14314 Close paritytech#4443 Ideally, we should move /health and /health/readiness to the prometheus server but because it's was quite easy to implement on the RPC server and that RPC server already exposes /health. Manual tests on a polkadot node syncing: ```bash ➜ polkadot-sdk (na-fix-4443) ✗ curl -v localhost:9944/health * Host localhost:9944 was resolved. * IPv6: ::1 * IPv4: 127.0.0.1 * Trying [::1]:9944... * connect to ::1 port 9944 from ::1 port 55024 failed: Connection refused * Trying 127.0.0.1:9944... * Connected to localhost (127.0.0.1) port 9944 > GET /health HTTP/1.1 > Host: localhost:9944 > User-Agent: curl/8.5.0 > Accept: */* > < HTTP/1.1 200 OK < content-type: application/json; charset=utf-8 < content-length: 53 < date: Fri, 14 Jun 2024 16:12:23 GMT < * Connection #0 to host localhost left intact {"peers":0,"isSyncing":false,"shouldHavePeers":false}% ➜ polkadot-sdk (na-fix-4443) ✗ curl -v localhost:9944/health/readiness * Host localhost:9944 was resolved. * IPv6: ::1 * IPv4: 127.0.0.1 * Trying [::1]:9944... * connect to ::1 port 9944 from ::1 port 54328 failed: Connection refused * Trying 127.0.0.1:9944... * Connected to localhost (127.0.0.1) port 9944 > GET /health/readiness HTTP/1.1 > Host: localhost:9944 > User-Agent: curl/8.5.0 > Accept: */* > < HTTP/1.1 500 Internal Server Error < content-type: application/json; charset=utf-8 < content-length: 0 < date: Fri, 14 Jun 2024 16:12:36 GMT < * Connection #0 to host localhost left intact ``` //cc @BulatSaif you may be interested in this.. --------- Co-authored-by: Bastian Köcher <[email protected]>
1 task
This was referenced Aug 21, 2024
DaMandal0rian
added a commit
to autonomys/subspace
that referenced
this pull request
Sep 12, 2024
DaMandal0rian
added a commit
to autonomys/subspace
that referenced
this pull request
Sep 12, 2024
1 task
nazar-pc
added a commit
to autonomys/subspace
that referenced
this pull request
Sep 12, 2024
* change health checkendpoint dockerfiles elated to paritytech/polkadot-sdk#4802 * Add http:// prefix --------- Co-authored-by: Nazar Mokrynskyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous attempt paritytech/substrate#14314
Close #4443
Ideally, we should move /health and /health/readiness to the prometheus server but because it's was quite easy to implement on the RPC server and that RPC server already exposes /health.
Manual tests on a polkadot node syncing:
//cc @BulatSaif you may be interested in this..