-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[subsystem-bench] Trigger own assignments in approval-voting #4772
Conversation
keystore | ||
.sr25519_generate_new( | ||
ASSIGNMENT_KEY_TYPE_ID, | ||
Some(state.test_authorities.key_seeds.first().unwrap().as_str()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: state.test_authorithies.key_seeds.get(NODE_UNDER_TEST) to make it future proof.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we already do it:
polkadot-sdk/polkadot/node/subsystem-bench/src/lib/approval/message_generator.rs
Line 304 in ad86209
let _public = store |
No, that's for the keystore we use for generating the messages for all other nodes in the network, the change here is the keystore that we provide to approval-voting when we instantiate it. |
The CI pipeline was cancelled due to failure one of the required jobs. |
Since #4772, the benchamrks triggers its own assignments, but the mocks weren't properly hooked up, so that the approval is sent as well, so they would have counted as no-shows and impact the time it takes for a block to be approved. Fixed by adding mocks for availability recovery and candidate-validation and hook those into the benchmark. Signed-off-by: Alexandru Gheorghe <[email protected]>
Since #4772, the benchamrks triggers its own assignments, but the mocks weren't properly hooked up, so that the approval is sent as well, so they would have counted as no-shows and impact the time it takes for a block to be approved. Fixed by adding mocks for availability recovery and candidate-validation and hook those into the benchmark. Signed-off-by: Alexandru Gheorghe <[email protected]>
…h#5042) Since paritytech#4772, the benchamrks triggers its own assignments, but the mocks weren't properly hooked up, so that the approval is sent as well, so they would have counted as no-shows and impact the time it takes for a block to be approved. Fixed by adding mocks for availability recovery and candidate-validation and hook those into the benchmark. Signed-off-by: Alexandru Gheorghe <[email protected]>
The accepted divergence rate of 1/1000 is execesive and leads to false positives especially after #4772 and #5042, so let's increase it to 1/100 since we do have some randomness in the system and there is no point in being that strict. Signed-off-by: Alexandru Gheorghe <[email protected]>
The accepted divergence rate of 1/1000 is excessive and leads to false positives especially after #4772 and #5042, so let's increase it to 1/100 since we do have some randomness in the system and there is no point in being that strict. Fixes: #5463 --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
No description provided.