Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secretary Program #4764

Closed

Conversation

Doordashcon
Copy link
Contributor

@Doordashcon Doordashcon commented Jun 11, 2024

On Chain Structure

The on-chain program consists of one rank and the default Candidate:

Secretary(rank 1) with the corresponding Origin(Secretary), which represents the collective voice of members of that rank.

Referendum

The SecretaryReferenda instance of referenda pallet consists of one track, corresponding to its Origin and invites all members to vote.

Membership Management

Governing parameters(i.e active_salary, passive_salary, demotion_period e.t.c.) are set by FellowshipAdmin and Fellows(DAN III) Origins.

Members themselves are without the power to promote or demote, this right is reserved to token holders via Polkadot OpenGov and votes by Fellow of the Technical Fellowship.

Fellowship Program Referendum

The Secretary Program can submit proposals on behalf of the fellowship program on any track.

@Doordashcon Doordashcon marked this pull request as ready for review June 13, 2024 21:04
@Doordashcon
Copy link
Contributor Author

bot help

@command-bot
Copy link

command-bot bot commented Jun 14, 2024

@Doordashcon Requester could not be detected as a member of an allowed organization.

@Doordashcon
Copy link
Contributor Author

This is hopefully ready for review @ggwpez @muharem

Just weights left

@Doordashcon Doordashcon requested a review from a team as a code owner June 28, 2024 15:50
prdoc/pr_4764.prdoc Outdated Show resolved Hide resolved
Copy link
Contributor

@muharem muharem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only setup ranked collective and salary pallet. We can extend later if needed.
@ggwpez what you think?

prdoc/pr_4764.prdoc Outdated Show resolved Hide resolved
@ggwpez
Copy link
Member

ggwpez commented Jul 2, 2024

I would only setup ranked collective and salary pallet. We can extend later if needed.

Wasnt sure about this, as automatic demotions and evidence submission could also be useful. Will ask in chat.

@paritytech-review-bot paritytech-review-bot bot requested a review from a team July 5, 2024 08:35
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6632001

@Doordashcon
Copy link
Contributor Author

@ggwpez @muharem @franciscoaguirre please review 🙏

Copy link
Contributor

@muharem muharem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot really imagine the use case for the referenda among one person. The rest looks good.

authors.workspace = true
edition.workspace = true
license = "Apache-2.0"
description = "Westend Collectives Parachain Runtime Constants"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "Westend Collectives Parachain Runtime Constants"
description = "Westend Collectives Parachain Runtime Constants"

Comment on lines +61 to +64
EnsureXcm<IsVoiceOfBody<GovernanceLocation, FellowshipAdminBodyId>>,
Replace<ConstU16<2>>,
>,
MapSuccess<Fellows, Replace<ConstU16<2>>>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see a reason to limit with 2, and might be easily forgotten to be updated

@bkchr
Copy link
Member

bkchr commented Jul 24, 2024

This should be a backport after the fellowship pr got merged.

@bkchr bkchr closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants