-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secretary Program #4764
Secretary Program #4764
Conversation
bot help |
@Doordashcon Requester could not be detected as a member of an allowed organization. |
cumulus/parachains/runtimes/collectives/collectives-westend/src/fellowship/mod.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/collectives/collectives-westend/src/secretary/mod.rs
Show resolved
Hide resolved
cumulus/parachains/runtimes/collectives/collectives-westend/src/secretary/mod.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/collectives/collectives-westend/src/secretary/mod.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/collectives/collectives-westend/src/secretary/mod.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/collectives/collectives-westend/src/secretary/origins.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/collectives/collectives-westend/src/secretary/tracks.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would only setup ranked collective and salary pallet. We can extend later if needed.
@ggwpez what you think?
Wasnt sure about this, as automatic demotions and evidence submission could also be useful. Will ask in chat. |
The CI pipeline was cancelled due to failure one of the required jobs. |
cumulus/parachains/runtimes/assets/asset-hub-westend/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/collectives/collectives-westend/src/secretary/mod.rs
Show resolved
Hide resolved
cumulus/parachains/runtimes/collectives/collectives-westend/src/secretary/mod.rs
Outdated
Show resolved
Hide resolved
@ggwpez @muharem @franciscoaguirre please review 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot really imagine the use case for the referenda among one person. The rest looks good.
authors.workspace = true | ||
edition.workspace = true | ||
license = "Apache-2.0" | ||
description = "Westend Collectives Parachain Runtime Constants" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "Westend Collectives Parachain Runtime Constants" | |
description = "Westend Collectives Parachain Runtime Constants" | |
EnsureXcm<IsVoiceOfBody<GovernanceLocation, FellowshipAdminBodyId>>, | ||
Replace<ConstU16<2>>, | ||
>, | ||
MapSuccess<Fellows, Replace<ConstU16<2>>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see a reason to limit with 2, and might be easily forgotten to be updated
This should be a backport after the fellowship pr got merged. |
On Chain Structure
The on-chain program consists of one rank and the default Candidate:
Secretary(rank 1) with the corresponding Origin(
Secretary
), which represents the collective voice of members of that rank.Referendum
The SecretaryReferenda instance of referenda pallet consists of one track, corresponding to its Origin and invites all members to vote.
Membership Management
Governing parameters(i.e
active_salary
,passive_salary
,demotion_period
e.t.c.) are set by FellowshipAdmin and Fellows(DAN III
) Origins.Members themselves are without the power to promote or demote, this right is reserved to token holders via Polkadot OpenGov and votes by Fellow of the Technical Fellowship.
Fellowship Program Referendum
The Secretary Program can submit proposals on behalf of the fellowship program on any track.