-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ability to specify chain type in chain-spec-builder #4542
Conversation
I wonder though, does this make any tangible difference other than changing the What would be cool if the cc @michalkucharczyk should the runtime be aware of the |
I feel it is easier to just have another tool to modify the JSON file |
With this change, PJS is able to show development accounts for chain types other than live. They do not carry any balance though at the moment. Happy to look into including that as well. For now, I had modified Without this change, I was unable to interact with PJS using development accounts at all. |
Yeah I am also leaning toward the fact that if this is just modifying the JSON file, it can be done with hand. |
Do we know how to serialize keys to json (which is domain of runtime)?
Well I like to ask question does this property belong to runtime domain? |
Adding flags like this is fine for me. No need to run additional tool. |
…k into gupnik/chain-spec
The CI pipeline was cancelled due to failure one of the required jobs. |
* master: (106 commits) [ci] Delete unused flow (#4676) Fix umbrella CI check and fix the C&P message (#4670) Add Dockerfiles to the templates (#4637) Revamp the Readme of the minimal template (#4649) Add chain-spec-builder docker image (#4655) Update Amforc bootnodes for Kusama and Polkadot (#4668) make all storage items in parachain-system public (#4645) [Pools] Refactors and runtime apis for DelegateStake (#4537) update amforc westend and its parachain bootnodes (#4641) Better error for missing index in CRV2 (#4643) Implement `XcmPaymentApi` and `DryRunApi` on all system parachains (#4634) Use Unlicense for templates (#4628) collator-protocol: remove `elastic-scaling-experimental` feature (#4595) Update `runtime_type` ref doc with the new "Associated Type Bounds" (#4624) Adds ability to specify chain type in chain-spec-builder (#4542) Fix broken windows build (#4636) Beefy client generic on aduthority Id (#1816) pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620) Broker new price adapter (#4521) Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621) ...
…4542) Currently, `chain-spec-builder` only creates a spec with `Live` chain type. This PR adds the ability to specify it while keeping the same default. --------- Co-authored-by: Kian Paimani <[email protected]>
…4542) Currently, `chain-spec-builder` only creates a spec with `Live` chain type. This PR adds the ability to specify it while keeping the same default. --------- Co-authored-by: Kian Paimani <[email protected]>
Currently,
chain-spec-builder
only creates a spec withLive
chain type. This PR adds the ability to specify it while keeping the same default.