Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracts: Remove topics for internal events #4510

Merged
merged 3 commits into from
May 17, 2024
Merged

Contracts: Remove topics for internal events #4510

merged 3 commits into from
May 17, 2024

Conversation

pgherveou
Copy link
Contributor

No description provided.

@pgherveou pgherveou requested a review from athei as a code owner May 17, 2024 12:18
athei
athei approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Topics are not really used outside of this pallet. Apps / Indexers tend to filter through all events anyways. But it incurs a lot of overhead due to all the storage accesses it adds.

Need a prdoc though as it is an observable change for clients.

@pgherveou pgherveou added the T7-smart_contracts This PR/Issue is related to smart contracts. label May 17, 2024
@pgherveou pgherveou enabled auto-merge May 17, 2024 13:13
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6237860

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6237859

@pgherveou pgherveou added this pull request to the merge queue May 17, 2024
Merged via the queue into master with commit a90d324 May 17, 2024
150 checks passed
@pgherveou pgherveou deleted the pg/fix_legacy_bench branch May 17, 2024 14:39
Ank4n pushed a commit that referenced this pull request May 21, 2024
@pgherveou @Ank4n
Contracts: Remove topics for internal events (#4510)
62df281
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@pgherveou @hitchhooker
Contracts: Remove topics for internal events (paritytech#4510)
0030d02
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@pgherveou @TarekkMA
Contracts: Remove topics for internal events (paritytech#4510)
c43afd8
This was referenced Aug 21, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@athei athei athei approved these changes

Assignees
No one assigned
Labels
T7-smart_contracts This PR/Issue is related to smart contracts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgherveou @paritytech-cicd-pr @ascjones @athei