-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xcm-emlator: Use BlockNumberFor
instead of parachains_common::BlockNumber=u32
#4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
added
R0-silent
Changes should not be mentioned in any release notes
T10-tests
This PR/Issue is related to tests.
labels
May 10, 2024
bkchr
approved these changes
May 10, 2024
sandreim
approved these changes
May 11, 2024
liamaharon
approved these changes
May 11, 2024
acatangiu
approved these changes
May 12, 2024
ordian
added a commit
that referenced
this pull request
May 14, 2024
* master: improve MockValidationDataInherentDataProvider to support async backing (#4442) Bump `proc-macro-crate` to the latest version (#4409) [ci] Run check-runtime-migration in GHA (#4441) prospective-parachains rework (#4035) [ci] Add forklift to GHA ARC (#4372) `CheckWeight` SE: Check for extrinsic length + proof size combined (#4326) Add generate and verify logic for `AncestryProof` (#4430) Rococo AH: undeploy trie migration (#4414) Remove `substrate-frame-cli` (#4403) migrations: `take()`should consume read and write operation weight (#4302) `remote-externalities`: store block header in snapshot (#4349) xcm-emlator: Use `BlockNumberFor` instead of `parachains_common::BlockNumber=u32` (#4434) Remove `pallet::getter` usage from authority-discovery pallet (#4091) Remove pallet::getter usage from pallet-contracts-mock-network (#4417) Add docs to request_core_count (#4423)
ntn-x2
pushed a commit
to KILTprotocol/polkadot-sdk
that referenced
this pull request
May 17, 2024
…kNumber=u32` (paritytech#4434) Closes: paritytech#4428 (cherry picked from commit 9e0e5fc)
acatangiu
pushed a commit
that referenced
this pull request
May 17, 2024
…kNumber=u32` (#4434) (#4493) Cherry-picked from `master` (#4434). Context: #4428. I don't see any other way than opening other PRs for each of the released branches with this fix. If you guys have an alternative proposal, I am all ears. Otherwise, I'll go ahead and open the other ones once this gets merged. Co-authored-by: Branislav Kontur <[email protected]>
ntn-x2
pushed a commit
to KILTprotocol/polkadot-sdk
that referenced
this pull request
May 17, 2024
…kNumber=u32` (paritytech#4434) (cherry picked from commit 9e0e5fc)
ntn-x2
pushed a commit
to KILTprotocol/polkadot-sdk
that referenced
this pull request
May 17, 2024
…kNumber=u32` (paritytech#4434) Closes: paritytech#4428
ntn-x2
pushed a commit
to KILTprotocol/polkadot-sdk
that referenced
this pull request
May 17, 2024
…kNumber=u32` (paritytech#4434) Closes: paritytech#4428
ntn-x2
pushed a commit
to KILTprotocol/polkadot-sdk
that referenced
this pull request
May 17, 2024
…kNumber=u32` (paritytech#4434) Closes: paritytech#4428
ntn-x2
pushed a commit
to KILTprotocol/polkadot-sdk
that referenced
this pull request
May 17, 2024
…kNumber=u32` (paritytech#4434) Closes: paritytech#4428
acatangiu
pushed a commit
that referenced
this pull request
May 17, 2024
…kNumber=u32` (#4434) (#4496) Context: #4428 and #4493. Co-authored-by: Branislav Kontur <[email protected]>
acatangiu
pushed a commit
that referenced
this pull request
May 17, 2024
…kNumber=u32` (#4434) (#4497) Context: #4428 and #4493. Co-authored-by: Branislav Kontur <[email protected]>
acatangiu
pushed a commit
that referenced
this pull request
May 17, 2024
…kNumber=u32` (#4434) (#4498) Context: #4428 and #4493. Co-authored-by: Branislav Kontur <[email protected]>
acatangiu
pushed a commit
that referenced
this pull request
May 17, 2024
…kNumber=u32` (#4434) (#4499) Context: #4428 and #4493. Co-authored-by: Branislav Kontur <[email protected]>
acatangiu
pushed a commit
that referenced
this pull request
May 17, 2024
…kNumber=u32` (#4434) (#4500) Context: #4428 and #4493. Co-authored-by: Branislav Kontur <[email protected]>
hitchhooker
pushed a commit
to ibp-network/polkadot-sdk
that referenced
this pull request
Jun 5, 2024
…kNumber=u32` (paritytech#4434) Closes: paritytech#4428
liuchengxu
pushed a commit
to liuchengxu/polkadot-sdk
that referenced
this pull request
Jun 19, 2024
…kNumber=u32` (paritytech#4434) Closes: paritytech#4428
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
…kNumber=u32` (paritytech#4434) Closes: paritytech#4428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4428