Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rococo_contracts: Adds missing migration #4112

Merged
merged 4 commits into from
Apr 14, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Apr 12, 2024

No description provided.

@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Apr 12, 2024
@bkchr bkchr requested review from pgherveou and athei April 12, 2024 21:32
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5916855

Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did CI not catch this? Maybe it should be mandatory to pass, since it has been stable for a while now (except westend until that is fixed)

@pgherveou
Copy link
Contributor

pgherveou commented Apr 14, 2024

To catch it you would need to dry run the migration with try-runtime as the list of migration that you need to setup here depend of what has already been deployed (v16 implied you are already on v15)

I am planning on switching to frame's mbm so hopefully we can add these safeguards there and not run into this again

#4058

@bkchr
Copy link
Member Author

bkchr commented Apr 14, 2024

Did CI not catch this? Maybe it should be mandatory to pass, since it has been stable for a while now (except westend until that is fixed)

CI catched this, the test was failing all the time

@liamaharon liamaharon added this pull request to the merge queue Apr 14, 2024
Merged via the queue into master with commit 88fe945 Apr 14, 2024
131 of 136 checks passed
@liamaharon liamaharon deleted the bkchr-contracts-rococo-fix-migration branch April 14, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants