-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove xcm::v3
from assets-common
nits
#4037
Conversation
…BackedAssetsConvertLatest from tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. This looks like it may impact downstream parachains though, is R0 an appropriate label?
yes, you're right, I added the prdoc. also waiting for merging #3695 first |
This PR mainly removes
xcm::v3
stuff fromassets-common
to make it more generic and facilitate the transition to newer XCM versions. Some of the implementations here used hard-codedxcm::v3::Location
, but now it's up to the runtime to configure according to its needs.Additional/consequent changes:
penpal
runtime uses nowxcm::latest::Location
forpallet_assets
asAssetId
, because we don't care about migrations hereimpl_assets_helpers_for_parachain
to theimpl_assets_helpers_for_parachain
andimpl_foreign_assets_helpers_for_parachain
(avoids using hard-codedxcm::v3::Location
)