Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 0007-dispute-freshly-finalized.zndsl failing #3893

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Fix 0007-dispute-freshly-finalized.zndsl failing #3893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions polkadot/zombienet_tests/functional/0007-dispute-freshly-finalized.zndsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ honest: reports polkadot_parachain_candidate_dispute_concluded{validity="valid"}
honest: reports polkadot_parachain_candidate_dispute_concluded{validity="invalid"} is 0 within 100 seconds

# Check lag - approval
honest: reports polkadot_parachain_approval_checking_finality_lag is 0
honest: reports polkadot_parachain_approval_checking_finality_lag is lower than 2

# Check lag - dispute conclusion
honest: reports polkadot_parachain_disputes_finality_lag is 0
honest: reports polkadot_parachain_disputes_finality_lag is lower than 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this metric also lagging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was let me figure it why.

Copy link
Contributor Author

@alexggh alexggh Apr 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's expected with the way we compute polkadot_parachain_disputes_finality_lag, because DetermineUndisputedChain

polkadot-sdk/polkadot/node/service/src/relay_chain_selection.rs

Line 515 in 809d466

block_descriptions: subchain_block_descriptions,
is called with the list of blocks that are already approved by approval-voting, so when we compute the disputes_finality_lag we already include in it the approval-voting-lag because the subchain number can't be higher than the highest approved block in approval-voting:

polkadot-sdk/polkadot/node/service/src/relay_chain_selection.rs

Line 530 in 809d466

let lag_disputes = initial_leaf_number.saturating_sub(subchain_number);



Loading