Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prdoc] Require SemVer bump level #3816

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Conversation

liamaharon
Copy link
Contributor

@liamaharon liamaharon commented Mar 25, 2024

A prerequisite for adding a stable branch and respecting SemVer on new stable releases is including SemVer bump levels in our PRDocs.

Next release is scheduled for April 3rd, so it would be great to get this merged before then.

Also added "None" as a valid bump option, to support test/benchmark changes and CI to ensure changed crates have an entry.

@liamaharon liamaharon added the R0-silent Changes should not be mentioned in any release notes label Mar 25, 2024
@liamaharon liamaharon requested a review from ggwpez March 25, 2024 07:29
@ggwpez
Copy link
Member

ggwpez commented Mar 25, 2024

@bkchr are you ready for this 🤣 ? We still need a script that checks that the Cargo.toml files are in sync (working on it).

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will never be fully ready for this until we merge it and force ourselves to be ready, nos vamos 🤠

@liamaharon
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Mar 27, 2024

@liamaharon https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5669798 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-ead29354-aefd-4cb0-85af-10c9ec6bd4c9 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Mar 27, 2024

@liamaharon Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5669798 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5669798/artifacts/download.

@liamaharon liamaharon added this pull request to the merge queue Mar 28, 2024
Merged via the queue into master with commit 1ed44af Mar 28, 2024
130 of 132 checks passed
@liamaharon liamaharon deleted the liam-mandatory-semver-bump-level branch March 28, 2024 08:50
ggwpez added a commit that referenced this pull request Apr 4, 2024
github-merge-queue bot pushed a commit that referenced this pull request Apr 5, 2024
Ank4n pushed a commit that referenced this pull request Apr 9, 2024
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
A prerequisite for adding a stable branch and respecting SemVer on new
stable releases is including SemVer bump levels in our PRDocs.

Next release is scheduled for April 3rd, so it would be great to get
this merged before then.

Also added "None" as a valid bump option, to support test/benchmark
changes and CI to ensure changed crates have an entry.
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants