[FRAME] Execution phases ApplyInherent and AfterInherent
#3666
+456
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
force-pushed
the
oty-inherent-execution-phase
branch
from
998d9f8 to
8e0bca6
Compare
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
muharem
reviewed
Jun 6, 2024
| @@ -601,8 +601,8 @@ where | |||
| DispatchClass::Mandatory, | |||
| ); | |||
|
|
|||
| frame_system::Pallet::<System>::note_finished_initialize(); | |||
| <System as frame_system::Config>::PreInherents::pre_inherents(); | |||
There was a problem hiding this comment.
here you wanna have it within Initialization phase?
There was a problem hiding this comment.
Yeah maybe some extra PreInherent phase? Similar to the AfterInherent one.
muharem
approved these changes
Jun 6, 2024
4 tasks
gui1117
approved these changes
Jul 27, 2024
This was referenced Nov 9, 2024
Merged
bkchr
approved these changes
Jan 2, 2025
| @@ -601,8 +601,8 @@ where | |||
| DispatchClass::Mandatory, | |||
| ); | |||
|
|
|||
| frame_system::Pallet::<System>::note_finished_initialize(); | |||
| <System as frame_system::Config>::PreInherents::pre_inherents(); | |||
There was a problem hiding this comment.
Yeah maybe some extra PreInherent phase? Similar to the AfterInherent one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #1781
Changes:
ApplyInherent(u32)andAfterInherent.System::note_after_inherents_doneto be called by Executive after running allafter_inherentslogic.on_pollhook.pre_inherentsinto the Initialization phase instead ofApplyExtrinsic.