Benchmarking: Add pov_mode to V2 syntax #3616
Conversation
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
bot bench substrate-pallet --pallet=frame_benchmarking_pallet_pov |
|
@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5469399 was started for your command Comment |
|
@ggwpez Command |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
added
T1-FRAME
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
bot bench substrate-pallet --pallet=pallet_whitelist |
|
@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5475514 was started for your command Comment |
| #[derive(Debug, Clone)] | ||
| struct PovModeAttr { |
There was a problem hiding this comment.
nit I would move the definition before the impl, I find it easier to scroll through the file this way
| let _ = || -> Result<()> { | ||
| let content; | ||
| syn::braced!(content in input); | ||
| maybe_content = Some(content); | ||
| Ok(()) | ||
| }(); |
There was a problem hiding this comment.
why do you need to return a Result here?
There was a problem hiding this comment.
The syn::braced! macro just does a return 🙈
Its internally using parse_braces, but that is private IIUC.
…=dev --target_dir=substrate --pallet=pallet_whitelist
|
@ggwpez Command |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
bot update-ui |
|
@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5547896 was started for your command Comment |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
@ggwpez Command |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Changes: - Port the `pov_mode` attribute from the V1 syntax to V2 - Update `pallet-whitelist` and `frame-benchmarking-pallet-pov` Follow up: also allow this attribute on top-level benchmark modules. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: command-bot <>
Changes:
pov_modeattribute from the V1 syntax to V2pallet-whitelistandframe-benchmarking-pallet-povFollow up: also allow this attribute on top-level benchmark modules.