Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pallet::getter usage from pallet-timestamp #3374

Merged
merged 12 commits into from
Jun 17, 2024
Merged

remove pallet::getter usage from pallet-timestamp #3374

merged 12 commits into from
Jun 17, 2024

Conversation

tesol2y090
Copy link
Contributor

this pr is a part of #3326

@tesol2y090 tesol2y090 requested a review from a team as a code owner February 17, 2024 19:24
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Feb 17, 2024

User @tesol2y090, please sign the CLA here.

@gupnik gupnik added the R0-silent Changes should not be mentioned in any release notes label Feb 18, 2024
@muraca
Copy link
Contributor

muraca commented Feb 19, 2024

CI is failing as there are various references to the Timestamp::now() function in other pallets (and I believe runtimes as well).
I think this is one of the few cases where an explicit getter should be preferred.

@muraca muraca mentioned this pull request Feb 19, 2024
Open
63 tasks
@tesol2y090
Copy link
Contributor Author

CI is failing as there are various references to the Timestamp::now() function in other pallets (and I believe runtimes as well). I think this is one of the few cases where an explicit getter should be preferred.

Yeah, they are in runtime and other pallets. I'll change it.

@muraca
Copy link
Contributor

muraca commented Feb 23, 2024

@tesol2y090 thanks! We need a prdoc for this PR, as it is a breaking change.

Can somebody remove the R0-silent label please?

@bkchr bkchr added T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed R0-silent Changes should not be mentioned in any release notes labels Feb 24, 2024
@kianenigma kianenigma added this pull request to the merge queue Mar 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2024
@muraca
Copy link
Contributor

muraca commented Mar 8, 2024

The merge failed for link errors that are not dependant on this PR.
Can we try again?

@github-actions GitHub Actions
Copy link

Review required! Latest push from author must always be reviewed

xlc
xlc reviewed Jun 14, 2024
View reviewed changes
prdoc/pr_3374.prdoc Outdated

crates:
- name: pallet-timestamp
- name: pallet-election-provider-multi-phase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why anyone using pallet-election-provider-multi-phas needs to care about this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In their test-staking-e2e, they call the timestamp pallet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test crate is not released.

bkchr
bkchr approved these changes Jun 17, 2024
View reviewed changes
prdoc/pr_3374.prdoc Outdated

crates:
- name: pallet-timestamp
- name: pallet-election-provider-multi-phase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test crate is not released.

prdoc/pr_3374.prdoc Outdated Show resolved Hide resolved
@tesol2y090 @bkchr
Update prdoc/pr_3374.prdoc
5b3f460 
Co-authored-by: Bastian Köcher <[email protected]>
@github-actions github-actions bot requested a review from bkchr June 17, 2024 21:32
@bkchr bkchr enabled auto-merge June 17, 2024 22:00
@bkchr bkchr added this pull request to the merge queue Jun 17, 2024
Merged via the queue into paritytech:master with commit 55a13ab Jun 17, 2024
156 of 157 checks passed
niklasad1 pushed a commit that referenced this pull request Jun 18, 2024
@tesol2y090 @kianenigma
@bkchr @niklasad1
remove pallet::getter usage from pallet-timestamp (#3374)
44346dd 
this pr is a part of #3326

---------

Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@tesol2y090 @kianenigma
@bkchr @TarekkMA
remove pallet::getter usage from pallet-timestamp (paritytech#3374)
654a6b2 
this pr is a part of paritytech#3326

---------

Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
This was referenced Aug 21, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc left review comments

@franciscoaguirre franciscoaguirre Awaiting requested review from franciscoaguirre

@ggwpez ggwpez Awaiting requested review from ggwpez

@gupnik gupnik Awaiting requested review from gupnik

@kianenigma kianenigma Awaiting requested review from kianenigma

@liamaharon liamaharon Awaiting requested review from liamaharon

@bkchr bkchr Awaiting requested review from bkchr

Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tesol2y090 @muraca @xlc @franciscoaguirre @kianenigma @bkchr @ggwpez @liamaharon @gupnik