Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Cargo.toml and crates.io versions #3034

Merged
merged 11 commits into from
Jan 26, 2024
Merged

Sync Cargo.toml and crates.io versions #3034

merged 11 commits into from
Jan 26, 2024

Conversation

liamaharon
Copy link
Contributor

Related #3032

Using https://github.com/liamaharon/cargo-workspace-version-tools/

cargo run -- sync --path ../polkadot-sdk

@liamaharon liamaharon requested review from ggwpez and a team January 23, 2024 15:27
@liamaharon liamaharon requested a review from a team January 23, 2024 15:27
@liamaharon liamaharon requested review from koute and a team as code owners January 23, 2024 15:27
@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 23, 2024 15:28
@liamaharon liamaharon added the A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Jan 23, 2024
@liamaharon liamaharon marked this pull request as draft January 23, 2024 15:31
@liamaharon liamaharon added R0-silent Changes should not be mentioned in any release notes A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes labels Jan 23, 2024
@liamaharon liamaharon marked this pull request as ready for review January 23, 2024 15:47
@liamaharon liamaharon mentioned this pull request Jan 23, 2024
Closed
@ggwpez ggwpez mentioned this pull request Jan 24, 2024
Closed
gavofyork
gavofyork approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@gavofyork gavofyork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty brutal, but looks about right.

@liamaharon liamaharon changed the title Sync local and remote crate versions Sync Cargo.toml and crates.io versions Jan 26, 2024
@ggwpez
Format TOML files
9e97ed6 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Copy link
Member

ggwpez commented Jan 26, 2024

The workspace integrity check failed 🤔
Going to take a look. Did you delete any crates?

@liamaharon
Copy link
Contributor Author

Did you delete any crates?

Nope. It says -1 crates are missing :P Could be a bug?

@ggwpez
Copy link
Member

ggwpez commented Jan 26, 2024

Okay it already fails on master 😑

@ggwpez
Copy link
Member

ggwpez commented Jan 26, 2024 •
edited
Loading

Okay I found it, its unrelated. Then lets merge 🚀
PS: #3082

@liamaharon liamaharon enabled auto-merge January 26, 2024 13:55
@liamaharon liamaharon disabled auto-merge January 26, 2024 15:55
@liamaharon liamaharon enabled auto-merge January 26, 2024 15:57
@liamaharon liamaharon added this pull request to the merge queue Jan 26, 2024
Merged via the queue into master with commit 3717ec3 Jan 26, 2024
119 of 121 checks passed
@liamaharon liamaharon deleted the liam-sync-crate-versions branch January 26, 2024 22:02
al3mart pushed a commit that referenced this pull request Jan 29, 2024
@liamaharon @ggwpez @al3mart
Sync Cargo.toml and crates.io versions (#3034)
a9434fa 
Related #3032

---

Using https://github.com/liamaharon/cargo-workspace-version-tools/ 

`cargo run -- sync --path ../polkadot-sdk`

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
svyatonik added a commit to paritytech/parity-bridges-common that referenced this pull request Feb 6, 2024
@svyatonik
backport paritytech/polkadot-sdk#3034
7f4d5a3
svyatonik added a commit to paritytech/parity-bridges-common that referenced this pull request Feb 6, 2024
@svyatonik
Backport latest PRs from polkadot sdk (#2824)
555866b 
* backport paritytech/polkadot-sdk#3034

* backport paritytech/polkadot-sdk#3072

* backport paritytech/polkadot-sdk#3175

* backport paritytech/polkadot-sdk#2949

* Cargo.lock

* fix invalid copypaste
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@liamaharon @ggwpez
Sync Cargo.toml and crates.io versions (paritytech#3034)
da2a7f1 
Related paritytech#3032

---

Using https://github.com/liamaharon/cargo-workspace-version-tools/ 

`cargo run -- sync --path ../polkadot-sdk`

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
@svyatonik
Backport latest PRs from polkadot sdk (paritytech#2824)
bbc6edc 
* backport paritytech/polkadot-sdk#3034

* backport paritytech/polkadot-sdk#3072

* backport paritytech/polkadot-sdk#3175

* backport paritytech/polkadot-sdk#2949

* Cargo.lock

* fix invalid copypaste
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
@svyatonik
Backport latest PRs from polkadot sdk (paritytech#2824)
4d9a75a 
* backport paritytech/polkadot-sdk#3034

* backport paritytech/polkadot-sdk#3072

* backport paritytech/polkadot-sdk#3175

* backport paritytech/polkadot-sdk#2949

* Cargo.lock

* fix invalid copypaste
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
Backport latest PRs from polkadot sdk (#2824)
67a1c9a 
* backport #3034

* backport #3072

* backport #3175

* backport #2949

* Cargo.lock

* fix invalid copypaste
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@seadanda seadanda seadanda approved these changes

@ggwpez ggwpez ggwpez approved these changes

@bkontur bkontur bkontur approved these changes

@gavofyork gavofyork gavofyork approved these changes

@athei athei Awaiting requested review from athei

@sorpaas sorpaas Awaiting requested review from sorpaas sorpaas is a code owner

@andresilva andresilva Awaiting requested review from andresilva

@jsidorenko jsidorenko Awaiting requested review from jsidorenko

@cheme cheme Awaiting requested review from cheme cheme is a code owner

@koute koute Awaiting requested review from koute koute is a code owner

Assignees
No one assigned
Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liamaharon @ggwpez @gavofyork @bkontur @seadanda @acatangiu