Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dotgraph feature #2848

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Remove dotgraph feature #2848

merged 2 commits into from
Jan 4, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Jan 4, 2024

Apparently the implementation is broken and is generating warnings in the build. Not sure this was used any way by anyone.

Closes: #2836

Apparently the implementation is broken and is generating warnings in
the build. Not sure this was used any way by anyone.
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Jan 4, 2024
@bkchr bkchr requested a review from ggwpez January 4, 2024 09:24
Copy link
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a bug that needs fixed in orchestra. I created a ticket for it . I think it is fine to remove the feature for now.

@bkchr
Copy link
Member Author

bkchr commented Jan 4, 2024

This is actually a bug that needs fixed in orchestra.

Yes I know, but do you actually use this? I mean we have the warning about cycles there since 2 years and no one cares...

@bkchr bkchr merged commit 5b9e69d into master Jan 4, 2024
121 of 122 checks passed
@bkchr bkchr deleted the bkchr-remove-dotgraph-feature branch January 4, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orchestra-proc-macro warning in build log
3 participants