Fix clippy lints behind feature gates and introduce new CI step targeting all features

.gitlab/pipeline/check.yml

@@ -8,6 +8,7 @@ cargo-clippy:
     RUSTFLAGS: "-D warnings"
   script:
     - SKIP_WASM_BUILD=1 cargo clippy --all-targets --locked --workspace
+    - SKIP_WASM_BUILD=1 cargo clippy --all-targets --all-features --locked --workspace
 
 check-try-runtime:
   stage: check

Cargo.toml

@@ -481,25 +481,27 @@ suspicious_double_ref_op = { level = "allow", priority = 2 }
 
 [workspace.lints.clippy]
 all = { level = "allow", priority = 0 }
-correctness = { level = "deny", priority = 1 }
+correctness = { level = "warn", priority = 1 }
+complexity = { level = "warn", priority = 1 }
 if-same-then-else = { level = "allow", priority = 2 }
-complexity = { level = "deny", priority = 1 }
 zero-prefixed-literal = { level = "allow", priority = 2 }            # 00_1000_000
 type_complexity = { level = "allow", priority = 2 }                  # raison d'etre
 nonminimal-bool = { level = "allow", priority = 2 }                  # maybe
 borrowed-box = { level = "allow", priority = 2 }                     # Reasonable to fix this one
 too-many-arguments = { level = "allow", priority = 2 }               # (Turning this on would lead to)
+needless-lifetimes = { level = "allow", priority = 2 }               # generated code
 unnecessary_cast = { level = "allow", priority = 2 }                 # Types may change
 identity-op = { level = "allow", priority = 2 }                      # One case where we do 0 +
 useless_conversion = { level = "allow", priority = 2 }               # Types may change
-unit_arg = { level = "allow", priority = 2 }                         # styalistic.
-option-map-unit-fn = { level = "allow", priority = 2 }               # styalistic
-bind_instead_of_map = { level = "allow", priority = 2 }              # styalistic
+unit_arg = { level = "allow", priority = 2 }                         # stylistic
+option-map-unit-fn = { level = "allow", priority = 2 }               # stylistic
+bind_instead_of_map = { level = "allow", priority = 2 }              # stylistic
 erasing_op = { level = "allow", priority = 2 }                       # E.g. 0 * DOLLARS
 eq_op = { level = "allow", priority = 2 }                            # In tests we test equality.
 while_immutable_condition = { level = "allow", priority = 2 }        # false positives
 needless_option_as_deref = { level = "allow", priority = 2 }         # false positives
 derivable_impls = { level = "allow", priority = 2 }                  # false positives
+clone_on_copy = { level = "allow", priority = 2 }                    # false positives
 stable_sort_primitive = { level = "allow", priority = 2 }            # prefer stable sort
 extra-unused-type-parameters = { level = "allow", priority = 2 }     # stylistic
 default_constructed_unit_structs = { level = "allow", priority = 2 } # stylistic

cumulus/pallets/xcmp-queue/src/benchmarking.rs

@@ -85,7 +85,7 @@ mod benchmarks {
 		}
 
 		assert!(
-			OutboundXcmpStatus::<T>::get().iter().find(|p| p.recipient == para).is_none(),
+			!OutboundXcmpStatus::<T>::get().iter().any(|p| p.recipient == para),
 			"No messages in the channel; therefore removed."
 		);
 	}

substrate/frame/bounties/src/benchmarking.rs

@@ -222,7 +222,7 @@ benchmarks_instance_pallet! {
 		);
 	}
 	verify {
-		ensure!(missed_any == false, "Missed some");
+		ensure!(!missed_any, "Missed some");
 		if b > 0 {
 			ensure!(budget_remaining < BalanceOf::<T, I>::max_value(), "Budget not used");
 			assert_last_event::<T, I>(Event::BountyBecameActive { index: b - 1 }.into())

substrate/frame/contracts/src/benchmarking/mod.rs

@@ -2246,13 +2246,12 @@ benchmarks! {
 		let message_len = message.len() as i32;
 		let key_type = sp_core::crypto::KeyTypeId(*b"code");
 		let sig_params = (0..r)
-			.map(|i| {
+			.flat_map(|i| {
 				let pub_key = sp_io::crypto::sr25519_generate(key_type, None);
 				let sig = sp_io::crypto::sr25519_sign(key_type, &pub_key, &message).expect("Generates signature");
 				let data: [u8; 96] = [AsRef::<[u8]>::as_ref(&sig), AsRef::<[u8]>::as_ref(&pub_key)].concat().try_into().unwrap();
 				data
 			})
-			.flatten()
 			.collect::<Vec<_>>();
 		let sig_params_len = sig_params.len() as i32;
 

substrate/frame/fast-unstake/src/benchmarking.rs

@@ -162,7 +162,7 @@ benchmarks! {
 			fast_unstake_events::<T>().last(),
 			Some(Event::BatchChecked { .. })
 		));
-		assert!(stashes.iter().all(|(s, _)| request.stashes.iter().find(|(ss, _)| ss == s).is_some()));
+		assert!(stashes.iter().all(|(s, _)| request.stashes.iter().any(|(ss, _)| ss == s)));
 	}
 
 	register_fast_unstake {

substrate/frame/scheduler/src/migration.rs

@@ -105,7 +105,7 @@ pub mod v3 {
 			// Check that no agenda overflows `MaxScheduledPerBlock`.
 			let max_scheduled_per_block = T::MaxScheduledPerBlock::get() as usize;
 			for (block_number, agenda) in Agenda::<T>::iter() {
-				if agenda.iter().cloned().filter_map(|s| s).count() > max_scheduled_per_block {
+				if agenda.iter().cloned().flatten().count() > max_scheduled_per_block {
 					log::error!(
 						target: TARGET,
 						"Would truncate agenda of block {:?} from {} items to {} items.",
@@ -119,7 +119,7 @@ pub mod v3 {
 			// Check that bounding the calls will not overflow `MAX_LENGTH`.
 			let max_length = T::Preimages::MAX_LENGTH as usize;
 			for (block_number, agenda) in Agenda::<T>::iter() {
-				for schedule in agenda.iter().cloned().filter_map(|s| s) {
+				for schedule in agenda.iter().cloned().flatten() {
 					match schedule.call {
 						frame_support::traits::schedule::MaybeHashed::Value(call) => {
 							let l = call.using_encoded(|c| c.len());

substrate/primitives/core/src/paired_crypto.rs

@@ -128,7 +128,7 @@ pub mod ecdsa_bls377 {
 			let Ok(right_sig) = sig.0[ecdsa::SIGNATURE_SERIALIZED_SIZE..].try_into() else {
 				return false
 			};
-			bls377::Pair::verify(&right_sig, message.as_ref(), &right_pub)
+			bls377::Pair::verify(&right_sig, message, &right_pub)
 		}
 	}
 }